Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup boolean not adjustable #111

Closed
JKetelaar opened this issue Apr 16, 2021 · 2 comments · Fixed by #205
Closed

Backup boolean not adjustable #111

JKetelaar opened this issue Apr 16, 2021 · 2 comments · Fixed by #205
Assignees
Labels
enhancement Enhance an existing feature
Milestone

Comments

@JKetelaar
Copy link

Describe the bug

All template calls use backup: yes, for example:


This creates a lot of backup files once the role has run.

To reproduce

Steps to reproduce the behavior:

  1. Deploy NGINX Config role
  2. Deploy NGINX Config role again
  3. Check the /etc/nginx/conf.d/ directory for example; this will have a lot of backup files

Expected behavior

While having backup files is fine, it should be opt-out

Is this expected behavior? Or would you like an option where this is set from a var(iable)?

@alessfg
Copy link
Collaborator

alessfg commented Apr 16, 2021

That is the expected behaviour. That being said, I'm open to making it customisable so that people can opt-out of the backup feature.

@alessfg alessfg added the enhancement Enhance an existing feature label Apr 16, 2021
@alessfg alessfg added this to To do in NGINX Configuration via automation Apr 16, 2021
@JKetelaar
Copy link
Author

Wonderful, I'll work on that!

@alessfg alessfg added this to the 0.4.3 milestone Nov 2, 2021
@alessfg alessfg self-assigned this Dec 11, 2021
alessfg added a commit that referenced this issue Dec 14, 2021
NGINX Configuration automation moved this from To do to Done Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance an existing feature
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants