Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backup parameter optional #205

Merged
merged 3 commits into from Dec 14, 2021
Merged

Make backup parameter optional #205

merged 3 commits into from Dec 14, 2021

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Dec 14, 2021

Proposed changes

Add backup variable to template and upload parameters. Set to false if you don't want to keep backups of your previous NGINX config files. Closes #111.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Dec 14, 2021
@alessfg alessfg added the feature New feature or request label Dec 14, 2021
@alessfg alessfg added this to In progress in NGINX Configuration via automation Dec 14, 2021
@alessfg alessfg added this to the 0.5.0 milestone Dec 14, 2021
@alessfg alessfg merged commit 028f954 into main Dec 14, 2021
NGINX Configuration automation moved this from In progress to Done Dec 14, 2021
@alessfg alessfg deleted the make-backup-optional branch December 14, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Backup boolean not adjustable
1 participant