Skip to content

Commit

Permalink
Remove NGINX_VERSION from base images (#1503)
Browse files Browse the repository at this point in the history
  • Loading branch information
lucacome committed Apr 19, 2021
1 parent c556778 commit 46e66e0
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions build/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
# syntax=docker/dockerfile:1.0-experimental
ARG NGINX_VERSION=1.19.9
ARG BUILD_OS=debian

############################################# Base image for Debian #############################################
FROM nginx:$NGINX_VERSION AS debian
FROM nginx:1.19.9 AS debian
ARG IC_VERSION

LABEL version=debian-nginx-$NGINX_VERSION-$IC_VERSION
Expand All @@ -15,7 +14,7 @@ RUN apt-get update \


############################################# Base image for Alpine #############################################
FROM nginx:$NGINX_VERSION-alpine AS alpine
FROM nginx:1.19.9-alpine AS alpine
ARG IC_VERSION

LABEL version=alpine-nginx-$NGINX_VERSION-$IC_VERSION
Expand Down Expand Up @@ -139,9 +138,10 @@ COPY --chown=nginx:0 LICENSE /licenses

############################################# Base image for Openshift OSS #############################################
FROM openshift-base AS openshift
ARG NGINX_VERSION
ARG IC_VERSION

ENV NGINX_VERSION 1.19.9

LABEL image-version=ubi-nginx-$NGINX_VERSION-$IC_VERSION

RUN echo "[nginx]" >> /etc/yum.repos.d/nginx.repo \
Expand All @@ -153,6 +153,7 @@ RUN echo "[nginx]" >> /etc/yum.repos.d/nginx.repo \
&& yum install -y nginx-${NGINX_VERSION} \
&& rm /etc/yum.repos.d/nginx.repo


############################################# Base image for Openshift with NGINX Plus #############################################
FROM openshift-base AS openshift-plus
ARG IC_VERSION
Expand All @@ -179,7 +180,6 @@ COPY --chown=nginx:0 internal/configs/oidc/* /etc/nginx/oidc/

############################################# Build image for Opentracing Builder #############################################
FROM debian as opentracing-builder
ARG NGINX_VERSION
ARG NGINX_OPENTRACING=0.10.0
ARG OPENTRACING_VERSION=1.6.0

Expand All @@ -190,7 +190,6 @@ RUN apt-get update && apt-get install -y -q --fix-missing --no-install-recommend
cmake \
git \
libcurl4-openssl-dev \
libcurl4-openssl-dev \
libgeoip-dev \
liblmdb-dev \
libpcre3-dev \
Expand Down Expand Up @@ -234,11 +233,10 @@ RUN set -x \

############################################# Build image for Opentracing #############################################
FROM debian as opentracing
ARG NGINX_VERSION
ARG OPENTRACING_VERSION=1.6.0
ARG IC_VERSION

LABEL version=debian-nginx-opentracing-$NGINX_PLUS_VERSION-$IC_VERSION
LABEL version=debian-nginx-opentracing-$NGINX_VERSION-$IC_VERSION

COPY --from=opentracing-builder /nginx-${NGINX_VERSION}/objs/ngx_http_opentracing_module.so /usr/lib/nginx/modules/ngx_http_opentracing_module.so
COPY --from=opentracing-builder /usr/local/lib/libopentracing.so.${OPENTRACING_VERSION} /usr/local/lib/libopentracing.so.1
Expand Down

0 comments on commit 46e66e0

Please sign in to comment.