Remove NGINX_VERSION from base images #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
requested review from
a team,
ciarams87 and
soneillf5
and removed request for
a team
lucacome
commented
Apr 3, 2021
| ARG IC_VERSION | ||
|
|
||
| ENV NGINX_VERSION 1.19.9 |
There was a problem hiding this comment.
Unfortunately, the base image for openshift is not specific for NGINX and doesn't have the variable so we need to set it manually for now.
soneillf5
approved these changes
Apr 6, 2021
lucacome
force-pushed
the
chore/remove-nginx-var-from-base
branch
from
d701ab8
to
227a486
Compare
lucacome
force-pushed
the
chore/remove-nginx-var-from-base
branch
from
227a486
to
a75d592
Compare
lucacome
added a commit
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGINX_VERSIONis set in the base images, so it can be used where needed