Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenTracing images in Updater #2837

Merged
merged 3 commits into from Jul 12, 2022
Merged

Remove OpenTracing images in Updater #2837

merged 3 commits into from Jul 12, 2022

Conversation

lucacome
Copy link
Member

Removes OpentTracing images as they are on longer separate images.

To be merged after v2.3.0

@lucacome lucacome requested a review from a team July 11, 2022 22:09
@lucacome lucacome self-assigned this Jul 11, 2022
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #2837 (aa7e3ad) into main (7f0a491) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2837      +/-   ##
==========================================
- Coverage   53.12%   53.10%   -0.02%     
==========================================
  Files          58       58              
  Lines       15625    15625              
==========================================
- Hits         8300     8298       -2     
- Misses       7048     7050       +2     
  Partials      277      277              
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome requested a review from pleshakov July 12, 2022 18:20
@@ -138,17 +138,9 @@ jobs:
platforms: linux/arm,linux/arm64,linux/amd64,linux/ppc64le,linux/s390x
needs-updating: ${{ needs.check.outputs.needs-updating-debian }}
- image: alpine
marker: vsr
Copy link
Contributor

@pleshakov pleshakov Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're loosing a vsr marker? is it a problem? can we add it to any of the images?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good call, I've added them back in other images 👍

@lucacome lucacome merged commit b302af4 into main Jul 12, 2022
@lucacome lucacome deleted the chore/update-updater branch July 12, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants