Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OpenTracing images in Updater #2837

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Remove OpenTracing images in Updater #2837

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39c2941
Remove OpenTracing images in Updater
lucacome Jul 11, 2022
9f7db5f
Add back vsr and policies
lucacome Jul 12, 2022
aa7e3ad
Merge branch 'main' into chore/update-updater
lucacome Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 3 additions & 11 deletions .github/workflows/update-docker-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,19 +138,11 @@ jobs:
platforms: linux/arm,linux/arm64,linux/amd64,linux/ppc64le,linux/s390x
needs-updating: ${{ needs.check.outputs.needs-updating-debian }}
- image: alpine
marker: vsr
Copy link
Contributor

@pleshakov pleshakov Jul 12, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're loosing a vsr marker? is it a problem? can we add it to any of the images?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good call, I've added them back in other images 👍

marker: "vs or vsr"
platforms: linux/arm,linux/arm64,linux/amd64,linux/ppc64le,linux/s390x
needs-updating: ${{ needs.check.outputs.needs-updating-alpine }}
- image: alpine-opentracing
marker: policies
platforms: linux/arm,linux/arm64,linux/amd64,linux/ppc64le,linux/s390x
needs-updating: ${{ needs.check.outputs.needs-updating-alpine }}
- image: opentracing
marker: vs
platforms: linux/arm,linux/arm64,linux/amd64,linux/ppc64le,linux/s390x
needs-updating: ${{ needs.check.outputs.needs-updating-debian }}
- image: ubi
marker: ts
marker: "policies or ts"
platforms: linux/arm64,linux/amd64,linux/s390x
needs-updating: ${{ needs.check.outputs.needs-updating-ubi }}
steps:
Expand Down Expand Up @@ -221,7 +213,7 @@ jobs:
name=public.ecr.aws/nginx/nginx-ingress
flavor: |
latest=true
suffix=${{ contains(matrix.image, 'ubi') && '-ubi' || '' }}${{ contains(matrix.image, 'alpine') && '-alpine' || '' }}${{ contains(matrix.image, 'opentracing') && '-ot' || '' }},onlatest=true
suffix=${{ contains(matrix.image, 'ubi') && '-ubi' || '' }}${{ contains(matrix.image, 'alpine') && '-alpine' || '' }},onlatest=true
tags: |
type=raw,value=${{ needs.variables.outputs.kic-tag }}
type=raw,value=${{ steps.tag.outputs.short }}
Expand Down