automate kindest/node versions #4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4798 +/- ##
=======================================
Coverage 52.01% 52.01%
=======================================
Files 60 60
Lines 17313 17313
=======================================
Hits 9005 9005
Misses 7995 7995
Partials 313 313 ☔ View full report in Codecov by Sentry. |
j1m-ryan
changed the title
|
@jimf5 is it possible to run latest |
|
yeah i can change the logic for not scheduled commits, will do that now |
|
@vepatel its getting the kindest latest version for non scheduled runs also now, and seems to have passed all of them on |
vepatel
approved these changes
Dec 15, 2023
j1m-ryan
added a commit
to j1m-ryan/kubernetes-ingress
that referenced
this pull request
Dec 18, 2023
* automate kindest/node versions * fix typo * test github action * undo temporary test * exclude versions not in the form vX.Y.Z, eg alpha versions * update k8s_latest origin * trim the version from the start of the string
j1m-ryan
added a commit
that referenced
this pull request
Dec 18, 2023
* automate kindest/node versions (#4798) * automate kindest/node versions * fix typo * test github action * undo temporary test * exclude versions not in the form vX.Y.Z, eg alpha versions * update k8s_latest origin * trim the version from the start of the string * skip pr for get id token step (#4813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
#4771
Automate the
kindest/nodeversions so the tests use the latest patches of the 7 latest minior versions from docker hub.At the time of writing, the
latest_kindest_node_versionsvariable becomes this\"1.23.17\", \"1.24.15\", \"1.25.11\", \"1.26.6\", \"1.27.3\", \"1.28.0\", \"1.29.0\"I briefly switched a condtion to test what nightly would look like. Below is the tests that run upon changing switching scheduler condition. Which I have now switched back.
I cancelled the run as its the nightly suite, but it appeared to be running fine, and getting the correct versions.
Checklist
Before creating a PR, run through this checklist and mark each as complete.