Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick: automate kindest/node versions (#4798) #4812

Merged
merged 2 commits into from Dec 18, 2023

Conversation

j1m-ryan
Copy link
Member

@j1m-ryan j1m-ryan commented Dec 18, 2023

Proposed changes

cherry-pick ff9c6b8

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

* automate kindest/node versions

* fix typo

* test github action

* undo temporary test

* exclude versions not in the form vX.Y.Z, eg alpha versions

* update k8s_latest origin

* trim the version from the start of the string
@j1m-ryan j1m-ryan requested a review from a team as a code owner December 18, 2023 11:01
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b048376) 52.01% compared to head (cefa6e0) 52.03%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-3.4    #4812      +/-   ##
===============================================
+ Coverage        52.01%   52.03%   +0.02%     
===============================================
  Files               60       60              
  Lines            17313    17313              
===============================================
+ Hits              9005     9009       +4     
+ Misses            7995     7993       -2     
+ Partials           313      311       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx requested a review from a team December 18, 2023 11:40
@j1m-ryan j1m-ryan merged commit 5e571ed into nginxinc:release-3.4 Dec 18, 2023
62 checks passed
@j1m-ryan j1m-ryan deleted the release-3.4 branch December 18, 2023 18:22
@j1m-ryan j1m-ryan restored the release-3.4 branch February 9, 2024 10:29
@j1m-ryan j1m-ryan deleted the release-3.4 branch February 9, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

3 participants