Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS support for vs/vsr upstreams #621

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Add TLS support for vs/vsr upstreams #621

merged 1 commit into from
Jul 16, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Jul 15, 2019

Proposed changes

Closes #620

Add the possibility to configure TLS for Upstreams in VS/VSR. This will redirect the requests to the upstream using https or http depending on the user's configuration.

@Rulox Rulox self-assigned this Jul 15, 2019
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my review

docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
internal/configs/virtualserver.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm pending @pleshakov 's requested doc changes. :shipit:

@Rulox Rulox requested a review from pleshakov July 15, 2019 14:29
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit f5ac669 into master Jul 16, 2019
@Rulox Rulox deleted the upstream-tls branch July 16, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VirtualServer with SSL services?
3 participants