-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of clean arch flow dependencies #5
Merged
nglauber
merged 17 commits into
nglauber:master
from
GabrielBrasileiro:update_of_clean_arch_flow_dependencies
Nov 9, 2020
Merged
Update of clean arch flow dependencies #5
nglauber
merged 17 commits into
nglauber:master
from
GabrielBrasileiro:update_of_clean_arch_flow_dependencies
Nov 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hey @GabrielBrasileiro! Thank you very much for your contribution. 👍 I really liked it 👏 |
nglauber
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Glauber. I'm Gabriel and I would like to contribute with your repository. I know you from some talks and I'm a big fã of your book. 😆.
Enjoying the hacktober, I see a good improvement. When we're using clean arch we need make the domain agnostic by all layers of project, following the idea of ports and adapters (Implemented by hexagonal) I created the abstractions of data making the domain not know anything about that layer. 😃
With this update I include the ISP (Interface Segregation Principle) to data layer, to improve and make more simple if some person would like use two or more data sources. Koin works better with this logic because register the key in graph with the reified type declared in generic.
To we can isolate implementations with internal modifier I create an individual archive by layer to load koin modules.
I update the by inject of koin to viewModel in fragments to we can have this instance in Fragment lifecycle.
I included the tests and run the others to grant the quality. 🚀