Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of clean arch flow dependencies #5

Conversation

GabrielBrasileiro
Copy link
Contributor

@GabrielBrasileiro GabrielBrasileiro commented Oct 17, 2020

Hi, Glauber. I'm Gabriel and I would like to contribute with your repository. I know you from some talks and I'm a big fã of your book. 😆.

Enjoying the hacktober, I see a good improvement. When we're using clean arch we need make the domain agnostic by all layers of project, following the idea of ports and adapters (Implemented by hexagonal) I created the abstractions of data making the domain not know anything about that layer. 😃

With this update I include the ISP (Interface Segregation Principle) to data layer, to improve and make more simple if some person would like use two or more data sources. Koin works better with this logic because register the key in graph with the reified type declared in generic.

To we can isolate implementations with internal modifier I create an individual archive by layer to load koin modules.

I update the by inject of koin to viewModel in fragments to we can have this instance in Fragment lifecycle.

I included the tests and run the others to grant the quality. 🚀

@nglauber
Copy link
Owner

nglauber commented Nov 9, 2020

hey @GabrielBrasileiro! Thank you very much for your contribution. 👍 I really liked it 👏
Sorry for the late response ;)

@nglauber nglauber merged commit 4f527ef into nglauber:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants