Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unexpected accent from names without accents #281

Merged
merged 2 commits into from
Jun 5, 2022
Merged

fix: Remove unexpected accent from names without accents #281

merged 2 commits into from
Jun 5, 2022

Conversation

seanpoulter
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

🐞 There is an unexpected accent that appears in the last names without accents.

Issue Number: N/A

What is the new behavior?

  • Remove the unexpected character, ą

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

There is a spec that we would have expected to catch this. I've added a new test case to confirm the names without accents do not contain unexpected characters. You may have to update the character group as you add names, such as adding the ' for O'Reilly.

@NetanelBasal NetanelBasal merged commit 62783af into ngneat:main Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants