Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter notebooks with numerical experiments. #234

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

s-mandra
Copy link
Member

No description provided.

@s-mandra s-mandra added this to the Post-release fixes milestone Nov 13, 2019
@s-mandra s-mandra added the Numerics Related to numerical experiments label Nov 13, 2019
@s-mandra
Copy link
Member Author

s-mandra commented Dec 4, 2019

TODO:

  • Showing how fidelity works for few examples (BV, AK)
  • Scaling analysis for the computational cost of different architectures (SM, AK)
  • Show XEB (BV, SM, AK)

@alexandrupaler
Copy link
Contributor

@s-mandra I have seen that you changed cirq version. Did you encounter bugs with version 0.7?

@s-mandra
Copy link
Member Author

s-mandra commented Mar 1, 2020

@s-mandra I have seen that you changed cirq version. Did you encounter bugs with version 0.7?

Yes, I get weird errors from cirq. However, if I use #249 the error doesn't appear anymore. So I'm already merging that branch on this PR to avoid the use of cirq==0.6.0.

@alexandrupaler
Copy link
Contributor

@s-mandra: I see. The major change between 0.6 and 0.7 was the removal of Schedules. This has not been adapted in the master branch. The pypi packaging adapted the tests to not include references to Schedules. I guess that is why it is working when you use the pypi branch.

@s-mandra
Copy link
Member Author

s-mandra commented Mar 1, 2020

@s-mandra: I see. The major change between 0.6 and 0.7 was the removal of Schedules. This has not been adapted in the master branch. The pypi packaging adapted the tests to not include references to Schedules. I guess that is why it is working when you use the pypi branch.

Yes, it gives errors regarding Schedules. We should merge #249 to master asap to avoid any problems.

@s-mandra
Copy link
Member Author

s-mandra commented Mar 1, 2020

@s-mandra: I see. The major change between 0.6 and 0.7 was the removal of Schedules. This has not been adapted in the master branch. The pypi packaging adapted the tests to not include references to Schedules. I guess that is why it is working when you use the pypi branch.

Yes, it gives errors regarding Schedules. We should merge #249 to master asap to avoid any problems.

For now, I'm fixing this by specifying cirq=0.6 on master.

@alexandrupaler
Copy link
Contributor

alexandrupaler commented Mar 1, 2020 via email

@s-mandra
Copy link
Member Author

s-mandra commented Mar 1, 2020

the requirements.txt on master should already have 0.6 În dum., 1 mar. 2020 la 12:12, Salvatore Mandra notifications@github.com a scris:

@s-mandra https://github.com/s-mandra: I see. The major change between 0.6 and 0.7 was the removal of Schedules. This has not been adapted in the master branch. The pypi packaging adapted the tests to not include references to Schedules. I guess that is why it is working when you use the pypi branch. Yes, it gives errors regarding Schedules. We should merge #249 <#249> to master asap to avoid any problems. For now, I'm fixing this by specifying cirq=0.6 on master. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#234?email_source=notifications&email_token=AEHWGFOUDZ6ZR2QLVZRYB4LRFK6RZA5CNFSM4JM6OD2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENNJO2I#issuecomment-593139561>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEHWGFPV2SEJHVO4UQKUWQTRFK6RZANCNFSM4JM6OD2A .

Do we have to change the requirements to cirq=0.7 once #249 is merged to master?

@s-mandra s-mandra changed the title Jupyter notebooks with numerical experiments. Jupyter notebooks with numerical experiments (depends on: #279). Mar 1, 2020
@alexandrupaler
Copy link
Contributor

The change in requirements.txt is taken care of in the PR

@s-mandra s-mandra changed the title Jupyter notebooks with numerical experiments (depends on: #279). Jupyter notebooks with numerical experiments. Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Numerics Related to numerical experiments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants