Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Revamping the Navbar #1195

Closed
2 of 3 tasks
tamalCodes opened this issue Jan 12, 2024 · 25 comments
Closed
2 of 3 tasks

Feature: Revamping the Navbar #1195

tamalCodes opened this issue Jan 12, 2024 · 25 comments
Assignees
@pranay911
Labels
💡 feature This generally contains addition/changes to features. hard invite me to the organisation Sends an invitation to your community organisation. JWOC status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@tamalCodes
Copy link
Member

tamalCodes commented Jan 12, 2024 •
edited
Loading

Description

We will be working on revamping the navbar for the desktop implementing a clean and minimal look with just one call to action in focus.

Proposed Solution

I have made a basic Figma prototype which can be used for the same. The mobile view would be similar to what we have as of now. The colors and assets can be copied/exported from the design itself.

Important

Make sure you make the PR to the beta branch, not main

Screenshots

image

🥦 Browser

Brave

Checklist ✅
@tamalCodes tamalCodes added 💡 feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jan 12, 2024
@github-actions GitHub Actions
Copy link

Hello @tamalCodes, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@Himanxu1
Copy link

Hey would like to grab this one

@tamalCodes tamalCodes added status: wip 👩🏻‍💻 This issue/PR is actively being worked on. JWOC easy and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jan 13, 2024
@Sneha-Sonkar
Copy link

I would like to work on this issue under JWOC

@pranay911
Copy link
Contributor

Heyy I like to worked on this

@tamalCodes
Copy link
Member Author

Hi @Himanxu1 , would you be willing to work on this or should I assign to someone else ?

@ArshiyaArora
Copy link

hi @tamalCodes please assign me this issue under JWOC

@akash02ab
Copy link

hi @tamalCodes Please! Assign the issue to me, I am more than happy to contribute.

@gayathrik23
Copy link

hey @tamalCodes could you please assign me this issue. i like to contribute

@Hrx4
Copy link

Hrx4 commented Jan 16, 2024

Want to work on this issue under JWOC. Please assign it to me

@tamalCodes
Copy link
Member Author

Looks like @Himanxu1 is busy - @Sneha-Sonkar you can start if you are available (reply if yes).
Would like to get this done ASAP. Also let us know if you are a part of any OSS event.

@Sneha-Sonkar
Copy link

Looks like @Himanxu1 is busy - @Sneha-Sonkar you can start if you are available (reply if yes). Would like to get this done ASAP. Also let us know if you are a part of any OSS event.

@tamalCodes I am so sorry for replying this late, can i still take up this issue. I would love to work on it under JWOC. Yes, I am working on an issue but not in this project

@tamalCodes
Copy link
Member Author

Cool, you can start to build it then - would love to have it done in quickly if possible !

@Sneha-Sonkar
Copy link

thank you so much @tamalCodes I will try my best

@Sneha-Sonkar Sneha-Sonkar removed their assignment Jan 20, 2024
@Sneha-Sonkar
Copy link

@tamalCodes thanks a lot for giving me the opportunity to work on this project. Actually, due to some personal issues, I couldn't work on it the way I could have and I already took a lot of your time. I am immensely grateful to you for being so patient and considerate.

@pranay911
Copy link
Contributor

@tamalCodes Can u please assign this issue to me ?

@tamalCodes
Copy link
Member Author

tamalCodes commented Jan 20, 2024 •
edited
Loading

Sure @pranay911 , go ahead .

📑 Checklist in case you missed something

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

@pranay911
Copy link
Contributor

Hey, @tamalCodes I would like to know the which color code used for the navigation item.

@pranay911
Copy link
Contributor

pranay911 commented Jan 20, 2024 •
edited
Loading

image
Hey @tamalCodes I made some changes, please have a look

@tamalCodes
Copy link
Member Author

Hi @pranay911 please make a Pull request following the guidelines

pranay911 added a commit to pranay911/Milan that referenced this issue Jan 21, 2024
@pranay911
feat: revamping the Navbar ngoworldcommunity#1195
3f38589
@pranay911
Copy link
Contributor

Hi @pranay911 please make a Pull request following the guidelines

Done

@tamalCodes tamalCodes added hard and removed easy labels Jan 23, 2024
@RazaAbbas62
Copy link

Hi, can i do it or is it completed?

@pranay911
Copy link
Contributor

It is in progress

@RazaAbbas62
Copy link

It is in progress

Hey, Can i contribute in it?

@pranay911
Copy link
Contributor

I already raised a PR...

tamalCodes pushed a commit that referenced this issue Jan 30, 2024
@pranay911
feat: revamping the Navbar #1195 (#1199)
0ee5586 
* feat: revamping the Navbar #1195

* feat(button): add rounded button with border-radius 40px

* fix: resolve issue with Button Hover Effect
@tamalCodes tamalCodes added the invite me to the organisation Sends an invitation to your community organisation. label Mar 12, 2024
@github-actions GitHub Actions
Copy link

You are already a member of our Organisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranay911 pranay911

Labels
💡 feature This generally contains addition/changes to features. hard invite me to the organisation Sends an invitation to your community organisation. JWOC status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
Milan
Status: Merged/Discarded
Milestone
No milestone
Development

No branches or pull requests
9 participants
@akash02ab @pranay911 @tamalCodes @Himanxu1 @Hrx4 @Sneha-Sonkar @ArshiyaArora @RazaAbbas62 @gayathrik23