feat: revamping the Navbar #1195 #1199
Conversation
github-actions
bot
added
hacktoberfest-accepted
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @pranay911, thank you for raising a pull request.
Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this pull request is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
pranay911
changed the title
|
Hi @pranay911 this looks amazing however the navbar looks quite off-center. This is a design issue I guess, can anything be done so that we make the navbar more centred ? For example, take a look at |
tamalCodes
added
status: discuss 💬
|
Hi @tamalCodes I've considered all the approaches you mentioned. In the provided image, there's only one item on the right side. However, on your website, two buttons – "Contribute to Milan" and "Sign Up" – occupy some space. Due to this, the navigation items are not centered as expected. |
| text-align: center; | ||
| cursor: pointer; | ||
| border-radius: 8px; | ||
| border-radius: 40px; |
There was a problem hiding this comment.
The radius might be different at different places so make another variant that also defines the border radius of the button for example you can make a class called rounded-button which has a different border radius and the default button can have the radius that we previously had.
We can use this class in places where we need it.
There was a problem hiding this comment.
U mean hide contribute to milan button?
There was a problem hiding this comment.
So basically I create a another button with different border-radius...
tamalCodes
added
status: need changes 🚧
github-actions
bot
added
the
deployed
|
Hey @tamalCodes, good evening! Following our discussion, I've made the following changes:
|
|
Hey @tamalCodes, any updates on PR? |
|
Now its looks Pretty
|
|
This pull request has been deployed to Vercel.
|
There was a problem hiding this comment.
Amazing work 🎉
The changes look good to me and will be merged soon.
Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !
PLEASE DROP US A STAR, MEANS ALOT.
Happy Opensource 🚀.
Changed the color of the navigation item and Added a navigation button according to design.
📸 Screenshots