Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] API for add to cart functionality #708

Closed
3 tasks done
PatilHarshh opened this issue May 21, 2023 · 17 comments Β· Fixed by #938
Closed
3 tasks done

[FEATURE] API for add to cart functionality #708

PatilHarshh opened this issue May 21, 2023 · 17 comments Β· Fixed by #938
Assignees
Labels
area/logic This issue is related to a logic fix. πŸ’‘ feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level3 GSSOC 23 -> LEVEL 3 πŸ“ˆ Major This a breaking change as it changes different files, and dependencies. status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on.

Comments

@PatilHarshh
Copy link
Contributor

PatilHarshh commented May 21, 2023

Description

when we click to item purchase not showing adding option along with need to form items added in the navbar.

Screenshots

Screenshot (56)

πŸ₯¦ Browser

Google Chrome

Checklist βœ…

  • I checked and didn't find a similar issue
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (blank for no)
@PatilHarshh PatilHarshh added πŸ’‘ feature This generally contains addition/changes to features. status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. 🟨 priority: medium labels May 21, 2023
@github-actions
Copy link

Hello, @PatilHarshh, thank you for opening an issue.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@tamalCodes tamalCodes added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. and removed 🟨 priority: medium status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. labels May 22, 2023
@tamalCodes
Copy link
Member

This is a great feature - however I would like to have some of the previous tasks in #370 completed first, as folks are working on those, there might be huge conflicts. So for that reason I am putting this on hold, will be opened as time comes.

@tamalCodes tamalCodes added status: on hold 🚦 This issue/PR is on hold/blocked for now as other issues/PRs needs to be merged before this. and removed πŸ’‘ feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels May 24, 2023
@ngoworldcommunity ngoworldcommunity locked and limited conversation to collaborators May 24, 2023
@tamalCodes
Copy link
Member

Hi @PatilHarshh , you can start to work on this !

@ngoworldcommunity ngoworldcommunity unlocked this conversation Jun 2, 2023
@tamalCodes tamalCodes added area/logic This issue is related to a logic fix. 🟨 priority: medium πŸ’‘ feature This generally contains addition/changes to features. status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. gssoc23 This issue/PR is part of GSSOC'23. level3 GSSOC 23 -> LEVEL 3 and removed status: on hold 🚦 This issue/PR is on hold/blocked for now as other issues/PRs needs to be merged before this. labels Jun 2, 2023
@tamalCodes
Copy link
Member

Hi @PatilHarshh I need some clarifications on the issue too, let's just make sure we are on the same page.

  • currently, the product has no detailed page, so there is no proper add to cart button. It is currently added in Product description page is missingΒ #701 , so we would need to get the add to cart button there ONCE IT IS COMPLETED.
  • So I was wondering if you could explain me in details what are the changes you are making so that we know that there wont be any conflicts !

@PatilHarshh
Copy link
Contributor Author

so, my issue was about whenever client wish to buy product so he will generally click on "cart" so it will update the page the product page that client add products and finally payment gateway... @tamalCodes

@tamalCodes
Copy link
Member

Interesting, so I think it will be better to go step by step. For example, we have no current way of tracking the cart, there's no proper schema, or API defined for it in the backend.

So here's how you can proceed

So what I suggest is to wait for a while !
Once that issue is done/API is ready, you can start working on this.

How does this sounds ?

@PatilHarshh
Copy link
Contributor Author

PatilHarshh commented Jun 3, 2023 via email

@tamalCodes
Copy link
Member

Cool.

@tamalCodes tamalCodes removed the area/logic This issue is related to a logic fix. label Jun 3, 2023
@tamalCodes tamalCodes added the status: on hold 🚦 This issue/PR is on hold/blocked for now as other issues/PRs needs to be merged before this. label Jun 3, 2023
@ngoworldcommunity ngoworldcommunity locked and limited conversation to collaborators Jun 3, 2023
@tamalCodes
Copy link
Member

Hi @PatilHarshh , #804 has been completed, we now have an API to fetch a single product, you can now start with making an API that has the ability to add any product to the cart.

  • Make sure we have a proper cart schema!
  • We also need to make sure that the items in the cart are removable, or that more items can be added to the cart
  • We also need to make sure that the cart persists, and you cannot add to the cart if you are not logged in.
  • The cart is unique for every user so make sure it is done with care.

Assigning this to you.
Please make sure that you have read our documentation on Commiting guidelines and Pull request guidelines, without proper format the PR might be closed.

@ngoworldcommunity ngoworldcommunity unlocked this conversation Jun 7, 2023
@tamalCodes tamalCodes changed the title [FEATURE] Add to cart logo with its feature [FEATURE] API for add to cart functionality Jun 7, 2023
@tamalCodes tamalCodes added area/logic This issue is related to a logic fix. 🟨 priority: medium πŸ’‘ feature This generally contains addition/changes to features. status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. πŸ“ˆ Major This a breaking change as it changes different files, and dependencies. gssoc23 This issue/PR is part of GSSOC'23. level3 GSSOC 23 -> LEVEL 3 and removed status: on hold 🚦 This issue/PR is on hold/blocked for now as other issues/PRs needs to be merged before this. labels Jun 7, 2023
@PatilHarshh
Copy link
Contributor Author

@tamalCodes ok
looking...

@Sa91001 Sa91001 added 🟠 status: updates needed Needs progress report on the issue/PR and removed 🟠 status: updates needed Needs progress report on the issue/PR labels Jun 12, 2023
@PatilHarshh
Copy link
Contributor Author

hey @tamalCodes how you want to add the cart on click on cart button passing user id and product id with request this need to change the user Schema for that . Or Alternative of this will be to work on frontent react tools only

@tamalCodes
Copy link
Member

Hi @PatilHarshh , this issue is related to making an API for adding a product to a cart. For example, in our schema, we can add a new array to the User's schema where we have an array.

So whenever the user calls the add-to-cart API, we push the product itself in that API which in turn get's added to that array. Check this schema.

@PatilHarshh
Copy link
Contributor Author

PatilHarshh commented Jun 25, 2023

hey @tamalCodes !! I tried to messege you on discord but you didn't replied ...
please have look on api
Screenshot (110)

@tamalCodes
Copy link
Member

Please can you raise a PR ? and make sure to add a screen-record to it ?
That way it would be easier for me to see.

@PatilHarshh
Copy link
Contributor Author

ok

@tamalCodes tamalCodes added the invite me to the organisation Sends an invitation to your community organisation. label Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

We just made a new organization, Invitation sent to join the GitHub Organisation. Welcome to the community πŸŽ‰

Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/MilanCommunity/people

@github-actions github-actions bot closed this as completed Aug 9, 2023
@tamalCodes tamalCodes removed the invite me to the organisation Sends an invitation to your community organisation. label Aug 9, 2023
@tamalCodes tamalCodes reopened this Aug 9, 2023
@PatilHarshh
Copy link
Contributor Author

@tamalCodes merge !?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logic This issue is related to a logic fix. πŸ’‘ feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level3 GSSOC 23 -> LEVEL 3 πŸ“ˆ Major This a breaking change as it changes different files, and dependencies. status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants