Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add a scroll to top button on all pages #908

Closed
3 tasks done
karthiknadar1204 opened this issue Jun 29, 2023 · 7 comments · Fixed by #944
Closed
3 tasks done

[FEATURE] Add a scroll to top button on all pages #908

karthiknadar1204 opened this issue Jun 29, 2023 · 7 comments · Fixed by #944
Assignees
Labels
area/ui This issue is related to frontend/interface fix. 💡 feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. invite me to the organisation Sends an invitation to your community organisation. level1 GSSOC 23 -> LEVEL 1 status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@karthiknadar1204
Copy link
Contributor

Description

I was thinking of adding a scroll to top button on all the pages, I just saw that it is yet to be implemented on any page over the past two weeks, so though could give it a try .

For reference of my experience working with a similar issue, please refer issue #847

I can get it done quickly

Screenshots

No response

🥦 Browser

Google Chrome

Checklist ✅

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am willing to work on this issue (blank for no)
@karthiknadar1204 karthiknadar1204 added 💡 feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 29, 2023
@github-actions
Copy link

Hello, @karthiknadar1204, thank you for opening an issue.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource 🚀

@karthiknadar1204
Copy link
Contributor Author

I would like to work on this issue under gssoc'23

@tamalCodes
Copy link
Member

Hi @karthiknadar1204 , there is no concept of "getting it done quickly" in Opensource. I believe in your skills, but for now, I will put this issue on hold. Before moving on, I wait for at least 3-4 weeks and then I close an issue - in this case, I assigned them last week, so I will wait more - because contributors can be busy too, with 1000 different stuff.

We are not competing here for getting something done quickly, the goal is to give EVERYONE a chance, and to make sure there's a win-win scenario for everyone who is contributing to my project.

Anyways, putting this on-hold, this will be continued if #833 is discarded.

@tamalCodes tamalCodes added status: on hold 🚦 This issue/PR is on hold/blocked for now as other issues/PRs needs to be merged before this. and removed 💡 feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 29, 2023
@karthiknadar1204
Copy link
Contributor Author

Totally understandable,thank you so much ,will explore other issues to work with for time being.

@tamalCodes
Copy link
Member

Hi @karthiknadar1204 , you can work and make a PR on this if interested, thanks !

Remember, Good PR makes you a Good contributor !

We at Milan work hard to maintain the structure, and use conventional Pull request titles and commits. Without a proper template for the PR, not following the guidelines and spam might get the pull request closed, or banned.

  • Please make sure that you have read our documentation on Commiting guidelines and Pull request guidelines.

  • Once you have done the changes you can request a review. If I suggest changes again, do those and request a review again.

  • Make sure you DO NOT modify the PR template that we have, use it as it is.

  • Last but not least, be patient. It takes a while to review the changes and get it merged.

@tamalCodes tamalCodes added area/ui This issue is related to frontend/interface fix. 💡 feature This generally contains addition/changes to features. status: wip 👩🏻‍💻 This issue/PR is actively being worked on. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 and removed status: on hold 🚦 This issue/PR is on hold/blocked for now as other issues/PRs needs to be merged before this. labels Jul 16, 2023
@karthiknadar1204
Copy link
Contributor Author

Thank you,will get working on it

@tamalCodes tamalCodes mentioned this issue Jul 23, 2023
3 tasks
@tamalCodes tamalCodes added the invite me to the organisation Sends an invitation to your community organisation. label Aug 10, 2023
@github-actions
Copy link

You are already a member of our Organisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui This issue is related to frontend/interface fix. 💡 feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. invite me to the organisation Sends an invitation to your community organisation. level1 GSSOC 23 -> LEVEL 1 status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants