Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroll to top button #944

Merged
merged 9 commits into from
Jul 30, 2023

Conversation

karthiknadar1204
Copy link
Contributor

Related Issue

Closes: #908

Changes made πŸ‘·πŸ»β€β™‚οΈ

Added a scroll to top button on all the pages

Screenshots πŸ“Έ

https://www.awesomescreenshot.com/video/19278642?key=18bfa8d3804b0f3962d7a92b95f4da70

@github-actions github-actions bot added πŸ’‘ feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jul 20, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @karthiknadar1204, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource πŸš€

@github-actions github-actions bot temporarily deployed to Preview July 20, 2023 09:38 Inactive
@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jul 20, 2023
@tamalCodes tamalCodes added status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. area/ui This issue is related to frontend/interface fix. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jul 22, 2023
@tamalCodes tamalCodes changed the title feat: add scroll to top button on all pages feat: scroll to top button Jul 22, 2023
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, there are a couple of changes that I would need you to do:

  • In the components folder, we already have a folder called /Button, inside that you can make another folder called /BacktoTop.
  • Rename the files from GoToTop.jsx to BacktoTop.jsx and BacktoTop.css and put both of those files inside the /BacktoTop folder.

Next, we would talk about the design,

  • The button looks huge (take a look at the SS below), we need it to be the same way we have 2 of our buttons. Do take a look at the video below for a proper explanation. Make sure you have the sound turned on (1.25x is better)
BacktoTop.mp4

@tamalCodes tamalCodes added status: need changes 🚧 Changes have been requested for these PRs and removed status: wip πŸ‘©πŸ»β€πŸ’» This issue/PR is actively being worked on. labels Jul 22, 2023
@karthiknadar1204
Copy link
Contributor Author

Thank you for the review @tamalCodes ,Will get it done

@tamalCodes tamalCodes mentioned this pull request Jul 25, 2023
3 tasks
@karthiknadar1204
Copy link
Contributor Author

@tamalCodes Will push the changes soon, have my exams going on so on a tight schedule, will wrap up by this weekend.
Thank you

@tamalCodes
Copy link
Member

@tamalCodes Will push the changes soon, have my exams going on so on a tight schedule, will wrap up by this weekend. Thank you

No worries. Take your time.

@karthiknadar1204
Copy link
Contributor Author

Have resumed the work

@karthiknadar1204
Copy link
Contributor Author

karthiknadar1204 commented Jul 29, 2023

Have done all the requested changes, pushing the changes @tamalCodes

@karthiknadar1204
Copy link
Contributor Author

@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 5838aea
βœ… Preview: https://milan-o0xb767yt-iamtamal.vercel.app
πŸ” Inspect: https://vercel.com/iamtamal/milan/D6CbT3U94ooeMoq8yGYdqNgXeCCs

View Workflow Logs

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work !

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource πŸš€.

@tamalCodes tamalCodes merged commit 4bc2c5a into ngoworldcommunity:main Jul 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui This issue is related to frontend/interface fix. deployed This PR has been deployed to Vercel for testing. πŸ’‘ feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level1 GSSOC 23 -> LEVEL 1 status: need changes 🚧 Changes have been requested for these PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a scroll to top button on all pages
2 participants