-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scroll to top button #944
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @karthiknadar1204, thank you for opening a pull request.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.
Give us a β to show some support
Happy OpenSource π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, there are a couple of changes that I would need you to do:
- In the components folder, we already have a folder called
/Button
, inside that you can make another folder called/BacktoTop
. - Rename the files from
GoToTop.jsx
toBacktoTop.jsx
andBacktoTop.css
and put both of those files inside the/BacktoTop
folder.
Next, we would talk about the design,
- The button looks huge (take a look at the SS below), we need it to be the same way we have 2 of our buttons. Do take a look at the video below for a proper explanation. Make sure you have the sound turned on (1.25x is better)
BacktoTop.mp4
Thank you for the review @tamalCodes ,Will get it done |
@tamalCodes Will push the changes soon, have my exams going on so on a tight schedule, will wrap up by this weekend. |
No worries. Take your time. |
Have resumed the work |
Have done all the requested changes, pushing the changes @tamalCodes |
β¦to scroll feat:scroll enhancement
This pull request has been deployed to Vercel.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work !
The changes look good to me and will be merged soon.
Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !
Happy Opensource π.
Related Issue
Closes: #908
Changes made π·π»ββοΈ
Added a scroll to top button on all the pages
Screenshots πΈ
https://www.awesomescreenshot.com/video/19278642?key=18bfa8d3804b0f3962d7a92b95f4da70