Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: google authentication frontend #849

Merged
merged 24 commits into from
Jul 22, 2023
Merged

feat: google authentication frontend #849

merged 24 commits into from
Jul 22, 2023

Conversation

Santosh7017
Copy link
Contributor

Related Issue

Closes: #835

Changes made 👷🏻‍♂️

The present pull request incorporates modifications to the user login and page, encompassing the inclusion of a Google login button to facilitate user authentication through their Google account, ensuring a high level of convenience.

Screenshots 📸

Milan._.Home.-.mp4

@github-actions github-actions bot added 💡 feature This generally contains addition/changes to features. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 13, 2023
github-actions[bot]
github-actions bot reviewed Jun 13, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Santosh7017, thank you for opening a pull request.

Soon the maintainers/owner will review it and provide you with feedback/suggestions.
If you think it's something urgent, feel free to reach out to Tamal on Twitter.


Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jun 13, 2023
tamalCodes
tamalCodes requested changes Jun 14, 2023
View reviewed changes
src/service/MilanApi.js Outdated
} catch (error) {
toast.error(error, {
position: toast.POSITION.TOP_RIGHT,
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this code :

    toast.error(error, {
      position: toast.POSITION.TOP_RIGHT,
    });

and instead, use our personalised toasts in the format showSuccessToast("Hello") or showErrorToast ("Hello")

src/pages/user/UserLogin.jsx Outdated Show resolved Hide resolved
src/pages/user/UserRegister.jsx Outdated Show resolved Hide resolved
@tamalCodes tamalCodes added area/ui This issue is related to frontend/interface fix. status: need changes 🚧 Changes have been requested for these PRs 📈 Major This a breaking change as it changes different files, and dependencies. gssoc23 This issue/PR is part of GSSOC'23. level3 GSSOC 23 -> LEVEL 3 and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jun 14, 2023
@Santosh7017
Copy link
Contributor Author

Hey @tamalCodes
just changed the button design please have a look
image

is it good or need any changes

@tamalCodes
Copy link
Member

Please resolve the conflicts.

@Santosh7017
Copy link
Contributor Author

Hey @tamalCodes just changed the button design please have a look image

is it good or need any changes

Is it looking nice or need to change button position

@tamalCodes
Copy link
Member

Yep looks good. Please push these changes ASAP.

@tamalCodes
Copy link
Member

tamalCodes commented Jun 27, 2023 •
edited
Loading

Hi @Santosh7017 , when i was running it locally from port http://127.0.0.1:5173/user/register on clicking the google icon it takes me to /user/undefined which is the 404 page.

Also in the console/network it says: MilanApi.js:183 GET http://localhost:5000/auth/login/success net::ERR_FAILED 403 (Forbidden) though the backend is running fine.

How do I fix this ?

When I visited http://localhost:5000/auth/google/callback on your branch - with my .env files loaded.
This is what is shown:

image

@Santosh7017
Copy link
Contributor Author

Have you configured CLIENT ID and Key

@Santosh7017
Copy link
Contributor Author

Hello @tamalCodes, I have created a new branch called "GoogleAuthentication" after resolving conflicts to ensure it does not interfere with or disrupt the main code.

@Santosh7017
Copy link
Contributor Author

Here is a working video
https://github.com/tamalCodes/Milan/assets/73546536/6f8d545e-6fd3-40d3-bfd7-e5ed4ed322a0

@tamalCodes
Copy link
Member

Hi @Santosh7017 , the changes you made looks good to me - please fix the conflicts.

@Santosh7017
Copy link
Contributor Author

@tamalCodes resolved conflicts, please have a look

@Santosh7017
Copy link
Contributor Author

The code has already undergone modifications.

@Santosh7017
Copy link
Contributor Author

Hey @tamalCodes please review the new changes

@Santosh7017
Copy link
Contributor Author

Hey @tamalCodes,

@github-actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: f42ad73
✅ Preview: https://milan-igm7zw2gg-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/B81keQy82LkPFd3FB27vErZTSmVS

View Workflow Logs

@tamalCodes tamalCodes changed the base branch from main to santosh-google-auth July 22, 2023 15:16
tamalCodes
tamalCodes approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the base branch, i will do some more testing, a little bit of design changes and will then deploy it up to production.

Amazing work !

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource 🚀.

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. and removed status: need changes 🚧 Changes have been requested for these PRs labels Jul 22, 2023
@tamalCodes tamalCodes merged commit c115718 into ngoworldcommunity:santosh-google-auth Jul 22, 2023
5 checks passed
@tamalCodes tamalCodes mentioned this pull request Jul 22, 2023
Merged
tamalCodes added a commit that referenced this pull request Aug 1, 2023
@tamalCodes @Santosh7017
feat: google authentication frontend (#849) (#951)
0e641a2 
* feat: google authentication frontend (#849)

Co-authored-by: Tamal Das <tamalcodes@gmail.com>

* feat: button components

* feat: cookie based authentication added

* fix: removing logs and cookies on logout

* feat: adding debouncing to scroll

---------

Co-authored-by: Santosh  Morya <73546536+Santosh7017@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@tamalCodes tamalCodes tamalCodes approved these changes

Assignees

@Santosh7017 Santosh7017

Labels
area/ui This issue is related to frontend/interface fix. deployed This PR has been deployed to Vercel for testing. 💡 feature This generally contains addition/changes to features. gssoc23 This issue/PR is part of GSSOC'23. level3 GSSOC 23 -> LEVEL 3 📈 Major This a breaking change as it changes different files, and dependencies. status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Google authentication frontend
2 participants
@Santosh7017 @tamalCodes