Skip to content

Commit

Permalink
refactor(RouterStore): normalize actions (#1302)
Browse files Browse the repository at this point in the history
BREAKING CHANGE:

Normalize router store actions to be consistent with the other modules

BEFORE:
- ROUTER_REQUEST
- ROUTER_NAVIGATION
- ROUTER_CANCEL
- ROUTER_ERROR
- ROUTER_NAVIGATED

AFTER
- @ngrx/router-store/request
- @ngrx/router-store/navigation
- @ngrx/router-store/cancel
- @ngrx/router-store/error
- @ngrx/router-store/navigated
  • Loading branch information
timdeschryver authored and brandonroberts committed Aug 27, 2018
1 parent bf038d3 commit 466e2cd
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions modules/router-store/src/actions.ts
Expand Up @@ -14,7 +14,7 @@ import {
/**
* An action dispatched when a router navigation request is fired.
*/
export const ROUTER_REQUEST = 'ROUTER_REQUEST';
export const ROUTER_REQUEST = '@ngrx/router-store/request';

/**
* Payload of ROUTER_REQUEST
Expand All @@ -34,7 +34,7 @@ export type RouterRequestAction = {
/**
* An action dispatched when the router navigates.
*/
export const ROUTER_NAVIGATION = 'ROUTER_NAVIGATION';
export const ROUTER_NAVIGATION = '@ngrx/router-store/navigation';

/**
* Payload of ROUTER_NAVIGATION.
Expand All @@ -57,7 +57,7 @@ export type RouterNavigationAction<
/**
* An action dispatched when the router cancels navigation.
*/
export const ROUTER_CANCEL = 'ROUTER_CANCEL';
export const ROUTER_CANCEL = '@ngrx/router-store/cancel';

/**
* Payload of ROUTER_CANCEL.
Expand All @@ -82,7 +82,7 @@ export type RouterCancelAction<
/**
* An action dispatched when the router errors.
*/
export const ROUTER_ERROR = 'ROUTE_ERROR';
export const ROUTER_ERROR = '@ngrx/router-store/error';

/**
* Payload of ROUTER_ERROR.
Expand All @@ -107,7 +107,7 @@ export type RouterErrorAction<
/**
* An action dispatched after navigation has ended and new route is active.
*/
export const ROUTER_NAVIGATED = 'ROUTER_NAVIGATED';
export const ROUTER_NAVIGATED = '@ngrx/router-store/navigated';

/**
* Payload of ROUTER_NAVIGATED.
Expand Down

0 comments on commit 466e2cd

Please sign in to comment.