Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RouterStore): allow compilation with strictFunctionTypes #1385

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1344

What is the new behavior?

Move action type cast to inside the reducer

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Closes #1344

cc: @rkirov

Move action type cast to inside the reducer
@brandonroberts brandonroberts merged commit 0e38673 into master Oct 29, 2018
@brandonroberts brandonroberts deleted the pr/routerstore-reducer-action branch October 29, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router-store reducer does not compile with --strictFunctionTypes
2 participants