Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): call metareducer with the user's config initial state #1498

Merged
merged 1 commit into from
Jan 18, 2019
Merged

fix(store): call metareducer with the user's config initial state #1498

merged 1 commit into from
Jan 18, 2019

Conversation

itayod
Copy link
Contributor

@itayod itayod commented Jan 4, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

metaReducers for feature are called without the user's config initial state.

Closes #1464

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 4, 2019

Preview docs changes for 541d8df at https://previews.ngrx.io/pr1498-541d8df/

@itayod itayod force-pushed the fix-metareducer-initial-state-for-feature branch from 541d8df to fa9e982 Compare January 4, 2019 15:09
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 4, 2019

Preview docs changes for fa9e982 at https://previews.ngrx.io/pr1498-fa9e982/

timdeschryver
timdeschryver reviewed Jan 4, 2019
View reviewed changes
modules/store/src/utils.ts Outdated Show resolved Hide resolved
modules/store/src/utils.ts Outdated Show resolved Hide resolved
@itayod itayod force-pushed the fix-metareducer-initial-state-for-feature branch from fa9e982 to af0d621 Compare January 5, 2019 12:33
itayod
itayod commented Jan 5, 2019
View reviewed changes
modules/store/src/utils.ts Outdated Show resolved Hide resolved
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 5, 2019

Preview docs changes for af0d621 at https://previews.ngrx.io/pr1498-af0d621/

@itayod itayod force-pushed the fix-metareducer-initial-state-for-feature branch from af0d621 to d4af698 Compare January 5, 2019 14:13
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 5, 2019

Preview docs changes for d4af698 at https://previews.ngrx.io/pr1498-d4af698/

@itayod itayod force-pushed the fix-metareducer-initial-state-for-feature branch from d4af698 to a5cc8a9 Compare January 7, 2019 18:30
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 7, 2019

Preview docs changes for a5cc8a9 at https://previews.ngrx.io/pr1498-a5cc8a9/

@itayod
Copy link
Contributor Author

itayod commented Jan 12, 2019

@brandonroberts @timdeschryver
do you think we can close it?

@itayod itayod force-pushed the fix-metareducer-initial-state-for-feature branch from a5cc8a9 to 67b4d66 Compare January 15, 2019 19:18
@itayod itayod force-pushed the fix-metareducer-initial-state-for-feature branch from 67b4d66 to 9faad53 Compare January 15, 2019 19:24
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 15, 2019

Preview docs changes for 67b4d66 at https://previews.ngrx.io/pr1498-67b4d66/

@itayod itayod force-pushed the fix-metareducer-initial-state-for-feature branch from 9faad53 to 411da54 Compare January 15, 2019 19:30
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 15, 2019

Preview docs changes for 9faad53 at https://previews.ngrx.io/pr1498-9faad53/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 15, 2019

Preview docs changes for 411da54 at https://previews.ngrx.io/pr1498-411da54/

@itayod itayod force-pushed the fix-metareducer-initial-state-for-feature branch from 411da54 to 8183e8a Compare January 16, 2019 20:08
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 16, 2019

Preview docs changes for 8183e8a at https://previews.ngrx.io/pr1498-8183e8a/

timdeschryver
timdeschryver approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brandonroberts brandonroberts merged commit 2aabe0f into ngrx:master Jan 18, 2019
@brandonroberts
Copy link
Member

Thanks again @itayod!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts left review comments

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ngrx/entity and metaReducers with localStorageSync
4 participants
@itayod @ngrxbot @brandonroberts @timdeschryver