Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: enable immutability checks by default #2217

Closed
3 tasks
brandonroberts opened this issue Nov 5, 2019 · 2 comments · Fixed by #2266
Closed
3 tasks

Store: enable immutability checks by default #2217

brandonroberts opened this issue Nov 5, 2019 · 2 comments · Fixed by #2266
Labels
Accepting PRs Breaking Change community watch Someone from the community is working this issue/PR Project: Store
Projects
NgRx 9

Comments

@brandonroberts
Copy link
Member

brandonroberts commented Nov 5, 2019 •
edited

  • Enable the immutability runtime checks for the StoreModule config.
  • Update/remove the console warning message
  • Update schematics
@evgenyfedorenko
Copy link
Contributor

I can take this one if that is ok

@brandonroberts
Copy link
Member Author

Yep

@timdeschryver timdeschryver added Accepting PRs community watch Someone from the community is working this issue/PR labels Nov 6, 2019
@timdeschryver timdeschryver added this to To do in NgRx 9 via automation Nov 6, 2019
evgenyfedorenko added a commit to evgenyfedorenko/platform that referenced this issue Nov 15, 2019
@evgenyfedorenko
feat(store): enable immutability checks by default
9b11ebc 
Closes ngrx#2217
@evgenyfedorenko evgenyfedorenko mentioned this issue Nov 15, 2019
Merged
3 tasks
evgenyfedorenko added a commit to evgenyfedorenko/platform that referenced this issue Nov 17, 2019
@evgenyfedorenko
feat(store): removing the test for immutability checks
b78c59a 
Closes ngrx#2217
@timdeschryver timdeschryver moved this from To do to In progress in NgRx 9 Nov 18, 2019
NgRx 9 automation moved this from In progress to Done Jan 7, 2020
brandonroberts pushed a commit that referenced this issue Jan 7, 2020
@evgenyfedorenko @brandonroberts
feat(store): enable immutability checks by default (#2266)
1758d34 
Closes #2217

BREAKING CHANGE:

Immutability checks are enabled by default. 

BEFORE:

Immutability checks are opt-in.

AFTER:

If state or action is mutated then there will be a run time exception thrown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Breaking Change community watch Someone from the community is working this issue/PR Project: Store
Projects
No open projects
NgRx 9
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(store): enable immutability checks by default evgenyfedorenko/platform
3 participants
@brandonroberts @evgenyfedorenko @timdeschryver