Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schematics: use skipTests instead of spec #2242

Closed
3 tasks
timdeschryver opened this issue Nov 11, 2019 · 6 comments · Fixed by #2253
Closed
3 tasks

Schematics: use skipTests instead of spec #2242

timdeschryver opened this issue Nov 11, 2019 · 6 comments · Fixed by #2253
Labels
Accepting PRs Breaking Change community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor Project: Schematics
Projects
NgRx 9

Comments

@timdeschryver
Copy link
Member

With the new version of the Angular CLI, the spec option from the schematics has been removed. Instead, a skipTests option has been added.

We would like to keep our schematics in line with the Angular CLI schematics.

This change includes:

  • Modifying the schematic options
  • Update the schematics code
  • Uppdate the docs

For ref: angular/angular-cli@e92c46a
@timdeschryver timdeschryver added this to To do in NgRx 9 via automation Nov 11, 2019
@Jefiozie
Copy link
Contributor

I would like to work on it, if that is fine by you @timdeschryver

@timdeschryver
Copy link
Member Author

Sure, go ahead @Jefiozie.
Feel free to ping us if needed.

@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Nov 12, 2019
@Jefiozie
Copy link
Contributor

@timdeschryver thanks, I also see a change around style. Do you want me to change this I'm this issue/PR?

Jefiozie added a commit to Jefiozie/platform that referenced this issue Nov 13, 2019
@Jefiozie
fix(schematics): migrate spec to skipTest to be in line with Angular CLI
cfd397c 
Closes: ngrx#2242
@Jefiozie Jefiozie mentioned this issue Nov 13, 2019
Merged
3 tasks
@timdeschryver
Copy link
Member Author

Seems like I'm too late to answer 😅

@Jefiozie
Copy link
Contributor

haha, yeah I thought it would be fine so made the PR 👍

@timdeschryver
Copy link
Member Author

Yes, ofcourse - thanks!

@timdeschryver timdeschryver moved this from To do to In progress in NgRx 9 Nov 18, 2019
Jefiozie added a commit to Jefiozie/platform that referenced this issue Nov 18, 2019
@Jefiozie
fix(schematics): migrate spec to skipTest to be in line with Angular CLI
8461052 
Closes: ngrx#2242

BREAKING CHANGES:

To be inline with the Angular CLI, we migrated the `--spec` to `--skipTest`.
By default skipTest is false, this way you will always be provided with `*.spec.ts files`

BEFORE:

```sh

ng generate action User --spec

```

AFTER:

```sh

ng generate action User

```
Jefiozie added a commit to Jefiozie/platform that referenced this issue Jan 10, 2020
@Jefiozie
fix(schematics): migrate spec to skipTest to be in line with Angular CLI
7f0779a 
Closes: ngrx#2242

BREAKING CHANGES:

To be inline with the Angular CLI, we migrated the `--spec` to `--skipTest`.
By default skipTest is false, this way you will always be provided with `*.spec.ts files`

BEFORE:

```sh

ng generate action User --spec

```

AFTER:

```sh

ng generate action User

```
Jefiozie added a commit to Jefiozie/platform that referenced this issue Jan 15, 2020
@Jefiozie
fix(schematics): migrate spec to skipTest to be in line with Angular CLI
ff37330 
Closes: ngrx#2242

BREAKING CHANGES:

To be inline with the Angular CLI, we migrated the `--spec` to `--skipTest`.
By default skipTest is false, this way you will always be provided with `*.spec.ts files`

BEFORE:

```sh

ng generate action User --spec

```

AFTER:

```sh

ng generate action User

```
NgRx 9 automation moved this from In progress to Done Jan 16, 2020
brandonroberts pushed a commit that referenced this issue Jan 16, 2020
@Jefiozie @brandonroberts
fix(schematics): migrate spec to skipTest to be in line with Angular …
714ae5f 
…CLI (#2253)

Closes: #2242

BREAKING CHANGES:

To be inline with the Angular CLI, we migrated the `--spec` to `--skipTest`.
By default skipTest is false, this way you will always be provided with `*.spec.ts files`

BEFORE:

```sh

ng generate action User --spec

```

AFTER:

```sh

ng generate action User

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Breaking Change community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor Project: Schematics
Projects
No open projects
NgRx 9
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(schematics): migrate spec to skipTest to be in line with Angular CLI Jefiozie/platform
2 participants
@Jefiozie @timdeschryver