Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component-store): initial setup #2519

Merged
merged 5 commits into from
May 12, 2020
Merged

feat(component-store): initial setup #2519

merged 5 commits into from
May 12, 2020

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Skeleton for Component Store

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 7, 2020

Preview docs changes for da77ee9 at https://previews.ngrx.io/pr2519-da77ee9/

@brandonroberts
Copy link
Member

Side note: We should create a schematic for this, as we've had to this enough times with each new library

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component-store should also be added on the intro page

modules/component-store/README.md Outdated Show resolved Hide resolved
modules/component-store/package.json Outdated Show resolved Hide resolved
alex-okrushko and others added 2 commits May 8, 2020 20:07
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
@timdeschryver
Copy link
Member

@alex-okrushko can you also add it to the intro page?

@alex-okrushko
Copy link
Member Author

Thanks @timdeschryver
I missed the initial comment about it somehow 🤦‍♂️

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brandonroberts brandonroberts merged commit a2657ac into ngrx:master May 12, 2020
BioPhoton pushed a commit to BioPhoton/platform that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants