Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router-store): Add urlAfterRedirects to Minimal #2775

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Even if the developer is using RouterState.Minimal we should be providing the urlAfterRedirects property, that exists on NavigationEnd Router even.
Is got broken when the default implementation was switched from Full to Minimal, however our Minimal should still cover this case.

Also, fix the router tests - with just async () => they were not testing the assertions within subscribe(...) 😳
Discovered that, because I first try to fail the test, before making sure that new code passes.

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@alex-okrushko alex-okrushko merged commit 14553f6 into master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants