Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MinimalRouterStateSerializer to DefaultRouterStateSerializer #3416

Closed
2 tasks
timdeschryver opened this issue May 16, 2022 · 1 comment · Fixed by #3430
Closed
2 tasks

Rename MinimalRouterStateSerializer to DefaultRouterStateSerializer #3416

timdeschryver opened this issue May 16, 2022 · 1 comment · Fixed by #3430
Assignees
@david-shortman
Labels
14.x Breaking Change community watch Someone from the community is working this issue/PR Project: Router Store
Projects
NgRx 14

Comments

@timdeschryver
Copy link
Member

Information

  • Rename MinimalRouterStateSerializer to DefaultRouterStateSerializer
  • Rename DefaultRouterStateSerializer to FullRouterStateSerializer

For more info see #2812 (comment)

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@timdeschryver timdeschryver mentioned this issue May 16, 2022
Closed
@david-shortman
Copy link
Contributor

Feel free to assign to me- I'll take on the migrating schematic as well.

@markostanimirovic markostanimirovic added this to To do in NgRx 14 via automation May 16, 2022
@markostanimirovic markostanimirovic added the community watch Someone from the community is working this issue/PR label May 16, 2022
This was referenced May 25, 2022
Closed
Merged
Closed
@markostanimirovic markostanimirovic moved this from To do to In progress in NgRx 14 May 26, 2022
NgRx 14 automation moved this from In progress to Done Jun 6, 2022
brandonroberts pushed a commit that referenced this issue Jun 6, 2022
@david-shortman
refactor(router-store): change name for full router state serializer (#…
d443f50 
…3430)

Closes #3416

BREAKING CHANGES:

The full router state serializer has been renamed.

BEFORE:

The full router state serializer is named `DefaultRouterStateSerializer`

AFTER:

The full router state serializer is named `FullRouterStateSerializer`. A migration is provided to rename the export in affected projects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-shortman david-shortman

Labels
14.x Breaking Change community watch Someone from the community is working this issue/PR Project: Router Store
Projects
No open projects
NgRx 14
Done
Milestone
No milestone
3 participants
@markostanimirovic @david-shortman @timdeschryver