Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component-store): handle errors in next callback #3533

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

When anything is thrown from the first argument of tapResponse fn( aka next callback) it is not handled.

Closes # #3431

What is the new behavior?

When anything is thrown from the first argument of tapResponse fn( aka next callback) is now handled by the same error handler as the second argument (aka error callback).

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 15, 2022

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit f19ed90
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/62fa9e8ee3ca770008dc621d
😎 Deploy Preview https://deploy-preview-3533--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@timdeschryver timdeschryver merged commit 551c8eb into master Aug 16, 2022
@timdeschryver timdeschryver deleted the tap-response-error-in-next branch August 16, 2022 10:06
@timdeschryver
Copy link
Member

Thanks Alex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants