Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataPersistence Operators from Nx #3777

Closed
2 tasks
Coly010 opened this issue Feb 14, 2023 · 2 comments · Fixed by #3841
Closed
2 tasks

Add DataPersistence Operators from Nx #3777

Coly010 opened this issue Feb 14, 2023 · 2 comments · Fixed by #3841
Assignees

Comments

@Coly010
Copy link

Coly010 commented Feb 14, 2023

Which @ngrx/* package(s) are relevant/related to the feature request?

router-store

Information

Nx has DataPersistence operators that can be used to aid developers when writing NgRx Effects.

You can see these operators here: https://github.com/nrwl/nx/blob/master/packages/angular/src/runtime/nx/data-persistence.ts

These operators could provide a lot of value for NgRx users, including those that do not use Nx. If they were offered as part of the NgRx Suite of packages it would be very beneficial.

The @nrwl/angular Nx plugin that contains these operators is soon going to be a DevTool only, with no runtime exports, and it would be great if these operators could be preserved for the benefit of all NgRx users.

cc @brandonroberts

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@Armenvardanyan95
Copy link
Contributor

I actually quite like this. I always thought that effects are a bit hard when trying to do optimistic updates - canceling on error.

@Legiew
Copy link

Legiew commented Mar 23, 2023

Would be a great addition I think. We use these operators very often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants