Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): support inject for use-consistent-global-store-name rule #3983

Merged

Conversation

suke
Copy link
Contributor

@suke suke commented Aug 2, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, use-consistent-global-store-name rule throws the following error when the rule is violated using inject

An unhandled exception occurred: Cannot read properties of undefined (reading 'typeAnnotation')

Related to #3943

What is the new behavior?

Added handling of cases where typeAnnotation does not exist.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d0db9cb
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64ca6b2a733e1b00082f0b37

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suke

@brandonroberts brandonroberts merged commit caa74ff into ngrx:main Aug 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants