Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated LetModule #4077

Closed
2 tasks
timdeschryver opened this issue Oct 19, 2023 · 0 comments · Fixed by #4087
Closed
2 tasks

Remove deprecated LetModule #4077

timdeschryver opened this issue Oct 19, 2023 · 0 comments · Fixed by #4087
Labels
17.x Breaking Change Project: Component

Comments

@timdeschryver
Copy link
Member

timdeschryver commented Oct 19, 2023 •
edited

Which @ngrx/* package(s) are relevant/related to the feature request?

component

Information

Remove the deprecated LetModule in https://github.com/ngrx/platform/blob/main/modules/component/src/let/let.module.ts

This module got replaced with the standalone API's, and there's already a migration in place.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@timdeschryver timdeschryver mentioned this issue Oct 21, 2023
Merged
3 tasks
markostanimirovic pushed a commit that referenced this issue Oct 24, 2023
@timdeschryver
feat(component): remove LetModule (#4087)
f28ea71 
Closes #4077

BREAKING CHANGES:

The LetModule is removed in favor of the standalone LetDirective.

BEFORE:

import { LetModule } from '@ngrx/component';

@NgModule({
  imports: [
    // ... other imports
    LetModule,
  ],
})
export class MyFeatureModule {}

AFTER:

import { LetDirective } from '@ngrx/component';

@NgModule({
  imports: [
    // ... other imports
    LetDirective,
  ],
})
export class MyFeatureModule {}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
17.x Breaking Change Project: Component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(component): remove LetModule ngrx/platform
2 participants
@markostanimirovic @timdeschryver