fix(schematics): Remove peer dependencies on Angular DevKit #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,9 +24,5 @@ | |||
| "ng-update": { | |||
| "packageGroup": "NG_UPDATE_PACKAGE_GROUP", | |||
| "migrations": "NG_UPDATE_MIGRATIONS" | |||
| }, | |||
| "peerDependencies": { | |||
| "@angular-devkit/core": "NG_DEVKIT_VERSION", | |||
There was a problem hiding this comment.
I think this is the only place where we were using NG_DEVKIT_VERSION, thus we could also remove it from defaults.bzl.
The peer dependencies prevent you from using `ng update` since they are pinned to specific versions. We'll verify the schematics work across versions and rely on the dependencies provided implicitly with the CLI Closes #1206
brandonroberts
force-pushed
the
schematics-peer-deps
branch
from
93862d1
to
9a41cfc
Compare
timdeschryver
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peer dependencies prevent you from using
ng updatesince they are pinned to specific versions. We'll verify the schematics work across versions and rely on the dependencies provided implicitly with the CLICloses #1206