Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Store): don't call the projector function if there are no selectors and props #1515

Merged
merged 2 commits into from Jan 20, 2019

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Jan 18, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The first commit shows the current behavior, the second commit has the fix.

Closes #1501

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@brandonroberts brandonroberts merged commit e0ad3c3 into master Jan 20, 2019
@brandonroberts brandonroberts deleted the pr/empty-selectors-no-props branch January 20, 2019 02:47
@timdeschryver timdeschryver restored the pr/empty-selectors-no-props branch March 27, 2019 21:34
@timdeschryver timdeschryver deleted the pr/empty-selectors-no-props branch March 27, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateSelectorFactory returns entire state when provided an empty array of selectors
2 participants