Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changelog): fix example import statement #1569

Closed
wants to merge 1 commit into from
Closed

docs(changelog): fix example import statement #1569

wants to merge 1 commit into from

Conversation

jspieker
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The example import statement wrongfully shows an import of ofType from @ngrx/store.

What is the new behavior?

The example import now imports from @ngrx/effects.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.515% when pulling 954629d on jspieker:patch-2 into 01ff157 on ngrx:master.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 20, 2019

Preview docs changes for 954629d at https://previews.ngrx.io/pr1569-954629d/

@timdeschryver
Copy link
Member

The CHANGELOG is generated by the commits we push, thus we, unfortunately, can't update the CHANGELOG.

The migration on ngrx.io is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants