-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(schematics): rename template files to avoid compilation #1586
refactor(schematics): rename template files to avoid compilation #1586
Conversation
…/1566-Schematics--rename-template-files-to-avoid-compilation
Preview docs changes for 98017dd at https://previews.ngrx.io/pr1586-98017dd/ |
Preview docs changes for dd34bbb at https://previews.ngrx.io/pr1586-dd34bbb/ |
Thanks for review guys, will make the changes.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why some files are renamed and some aren't, more specific __dot__
to .
?
__name@dasherize__.effects__dot__spec.ts → ...name@dasherize__.effects.spec.ts.template
VS
name@dasherize__.component__dot__spec.ts → ...herize__.component__dot__spec.ts.template
If there wasn't a specific reason I would suggest to rename every __dot__
to .
.
My bad @timdeschryver, changed other files looks like this file got skipped,changing the same. |
Preview docs changes for 5e6a6ee at https://previews.ngrx.io/pr1586-5e6a6ee/ |
Preview docs changes for a5bd5b1 at https://previews.ngrx.io/pr1586-a5bd5b1/ |
Preview docs changes for 3cdf7f7 at https://previews.ngrx.io/pr1586-3cdf7f7/ |
Preview docs changes for 04bf8c5 at https://previews.ngrx.io/pr1586-04bf8c5/ |
@brandonroberts should i resolve all the conversations and thanks a lot for your help. |
@santoshyadav198613 no, you don't need to resolve those. Revert the yarn.lock change and I think everything else looks good. Thanks for taking this on! |
Sorry already marked them as reply and rolled-back all changes to lock file. |
Preview docs changes for a27e9af at https://previews.ngrx.io/pr1586-a27e9af/ |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
#1566
What is the new behavior?
Angular team introduced new method applyTemplates to handle this issue.
Update schematics to latest release and added it as dev dependency.
Does this PR introduce a breaking change?
Other information