Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(schematics): rename template files to avoid compilation #1586

Merged
merged 11 commits into from
Feb 28, 2019
Merged

refactor(schematics): rename template files to avoid compilation #1586

merged 11 commits into from
Feb 28, 2019

Conversation

santoshyadavdev
Copy link
Sponsor Contributor

@santoshyadavdev santoshyadavdev commented Feb 27, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #
#1566

What is the new behavior?

Angular team introduced new method applyTemplates to handle this issue.
Update schematics to latest release and added it as dev dependency.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 27, 2019

Preview docs changes for 98017dd at https://previews.ngrx.io/pr1586-98017dd/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 27, 2019

Preview docs changes for dd34bbb at https://previews.ngrx.io/pr1586-dd34bbb/

@coveralls
Copy link

coveralls commented Feb 27, 2019

Coverage Status

Coverage decreased (-0.01%) to 89.512% when pulling a27e9af on santoshyadav198613:bugfix/1566-Schematics--rename-template-files-to-avoid-compilation into 1613f50 on ngrx:master.

package.json Outdated Show resolved Hide resolved
modules/store/schematics/ng-add/index.ts Outdated Show resolved Hide resolved
modules/schematics/src/action/index.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@santoshyadavdev
Copy link
Sponsor Contributor Author

Thanks for review guys, will make the changes..

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why some files are renamed and some aren't, more specific __dot__ to .?

__name@dasherize__.effects__dot__spec.ts → ...name@dasherize__.effects.spec.ts.template
VS
name@dasherize__.component__dot__spec.ts → ...herize__.component__dot__spec.ts.template

If there wasn't a specific reason I would suggest to rename every __dot__ to ..

@santoshyadavdev
Copy link
Sponsor Contributor Author

dot

My bad @timdeschryver, changed other files looks like this file got skipped,changing the same.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 28, 2019

Preview docs changes for 5e6a6ee at https://previews.ngrx.io/pr1586-5e6a6ee/

modules/schematics/src/action/index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 28, 2019

Preview docs changes for a5bd5b1 at https://previews.ngrx.io/pr1586-a5bd5b1/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 28, 2019

Preview docs changes for 3cdf7f7 at https://previews.ngrx.io/pr1586-3cdf7f7/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 28, 2019

Preview docs changes for 04bf8c5 at https://previews.ngrx.io/pr1586-04bf8c5/

@santoshyadavdev
Copy link
Sponsor Contributor Author

@brandonroberts should i resolve all the conversations and thanks a lot for your help.

@brandonroberts
Copy link
Member

@santoshyadav198613 no, you don't need to resolve those. Revert the yarn.lock change and I think everything else looks good. Thanks for taking this on!

@santoshyadavdev
Copy link
Sponsor Contributor Author

@santoshyadav198613 no, you don't need to resolve those. Revert the yarn.lock change and I think everything else looks good. Thanks for taking this on!

Sorry already marked them as reply and rolled-back all changes to lock file.

@brandonroberts brandonroberts changed the title Bugfix/1566 schematics rename template files to avoid compilation refactor(schematics): rename template files to avoid compilation Feb 28, 2019
@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 28, 2019

Preview docs changes for a27e9af at https://previews.ngrx.io/pr1586-a27e9af/

@brandonroberts brandonroberts merged commit 049fc8f into ngrx:master Feb 28, 2019
tja4472 pushed a commit to tja4472/platform that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants