New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router-store) add selector to get title #3437
Conversation
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change creates a title selector, but the result is only undefined
.
We should also add title
to the serializers to be able to retrieve it from the Angular route.
My bad, added it now |
@santoshyadavdev will you resolve the merge conflicts? We're ready to merge it afterwards |
Let me do that 😊 |
Please check now. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3336
What is the new behavior?
Does this PR introduce a breaking change?
Other information