Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router-store) add selector to get title #3437

Merged
merged 1 commit into from Jun 7, 2022
Merged

feat(router-store) add selector to get title #3437

merged 1 commit into from Jun 7, 2022

Conversation

santoshyadavdev
Copy link
Sponsor Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3336

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented May 26, 2022

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 9573850
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/629e07bdb5075e0008ed7e97

@santoshyadavdev santoshyadavdev marked this pull request as draft May 26, 2022 21:39
@santoshyadavdev santoshyadavdev marked this pull request as ready for review May 26, 2022 22:05
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change creates a title selector, but the result is only undefined.
We should also add title to the serializers to be able to retrieve it from the Angular route.

@santoshyadavdev
Copy link
Sponsor Contributor Author

This change creates a title selector, but the result is only undefined. We should also add title to the serializers to be able to retrieve it from the Angular route.

My bad, added it now

@brandonroberts
Copy link
Member

@santoshyadavdev will you resolve the merge conflicts? We're ready to merge it afterwards

@santoshyadavdev
Copy link
Sponsor Contributor Author

Let me do that 😊

@santoshyadavdev
Copy link
Sponsor Contributor Author

@santoshyadavdev will you resolve the merge conflicts? We're ready to merge it afterwards

Please check now.

@timdeschryver timdeschryver merged commit 34174a7 into ngrx:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Add title to RouterStore selectors for Angular v14
4 participants