Default selectId function for EntityAdapter #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonroberts
requested changes
Sep 19, 2017
modules/entity/src/create_adapter.ts
Outdated
| @@ -10,10 +10,12 @@ import { createSelectorsFactory } from './state_selectors'; | |||
| import { createSortedStateAdapter } from './sorted_state_adapter'; | |||
| import { createUnsortedStateAdapter } from './unsorted_state_adapter'; | |||
|
|
|||
| export function createEntityAdapter<T>(options: { | |||
| export function createEntityAdapter<T>(options?: { | |||
There was a problem hiding this comment.
Instead of making options optional, make selectId optional and provide a default below
modules/entity/src/create_adapter.ts
Outdated
| selectId: IdSelector<T>; | ||
| sortComparer?: false | Comparer<T>; | ||
| }): EntityAdapter<T> { | ||
| options = options || { selectId: (instance: any) => instance.id }; | ||
|
|
||
| const { selectId, sortComparer }: EntityDefinition<T> = { | ||
| sortComparer: false, |
There was a problem hiding this comment.
Added a default selectId function here under the sortComparer
| @@ -149,12 +149,16 @@ export class StoreModule { | |||
| ): ModuleWithProviders; | |||
There was a problem hiding this comment.
Do these changes in a separate commit
There was a problem hiding this comment.
Hey Brandon, these changes are happening automatically as per the precommit script. Any suggestions on how to stop it.
There was a problem hiding this comment.
Don't worry about it then. Must have merged another change that didn't get formatted.
|
Hey @brandonroberts, The original request was to make it possible to create an adaptor using this I removed the optional options flag and replaced it with a default value if not provided. Hope this meets requirements. |
brandonroberts
approved these changes
Sep 19, 2017
|
Thanks! |
sharikovvladislav
added a commit
to sharikovvladislav/platform
that referenced
this pull request
Sep 28, 2017
* 'master' of github.com:ngrx/platform: (35 commits) chore(Example): Add login info to example app. Fix sidenav issue with IE (ngrx#436) chore(docs): Fix OnRunEffects example (ngrx#430) chore(docs): Add docs on usage of custom router state serializer with store freeze (ngrx#426) chore(docs): Add missing from in metareducer example. (ngrx#418) docs(Entity): Fix examples for @ngrx/entity usage (ngrx#415) feat(Entity): Add default selectId function for EntityAdapter (ngrx#405) fix(Example): Add missing import for catch operator (ngrx#409) docs(effects): Remove usage of deprecated `toPayload` util in example (ngrx#407) chore(Example): Add Jest as test runner for example tests (ngrx#371) fix(Store): Refactor parameter initialization in combineReducers for Closure feat(Entity): Rename 'sort' to 'sortComparer' chore(docs): Minor fixes to entity interfaces documentation (ngrx#390) chore(docs): Change providing injected reducers by factory instead of value (ngrx#387) fix(Store): Fix typing for feature to accept InjectionToken (ngrx#375) chore(docs): Update @ngrx/entity documentation examples and usage (ngrx#369) docs(entity): Fix typo in url (ngrx#365) chore(Example): Documented @ngrx/entity and added to example app (ngrx#328) fix(RouterStore): Stringify error from navigation error event (ngrx#357) chore(docs): Fix action interface example (ngrx#360) chore(Example): Added ngrx-store-freeze meta-reducer to example application (ngrx#343) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #378
What is the current behavior?
I have several entities, and I use always id property for the primary key. So, to create the EntityAdater I must repeat the code like:
Expected behavior:
This could be greate if createEntityAdapter uses a default selectId method which will take id property of object as a primary key. So I just need call this function