Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effects): add migrator for concatLatestFrom #4311

Merged

Conversation

rainerhahnekamp
Copy link
Contributor

Adds a migrator for version 18 which
replaces all concatLatestFrom imports
from @ngrx/effects to @ngrx/operators.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

Migration to @ngrx/operators

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #4262

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Adds a migrator for version 18 which
replaces all `concatLatestFrom` imports
from `@ngrx/effects` to `@ngrx/operators`.
Copy link

netlify bot commented May 1, 2024

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit d684d77
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/663a9651e544d60008961d11

@rainerhahnekamp
Copy link
Contributor Author

@markostanimirovic I'd suggest we make this one first and it will serve as a template for the component-store migrator

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
The version can be changed to the beta version.

modules/effects/migrations/migration.json Outdated Show resolved Hide resolved
modules/effects/migrations/18_0_0/index.spec.ts Outdated Show resolved Hide resolved
rainerhahnekamp and others added 2 commits May 5, 2024 00:32
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
rainerhahnekamp and others added 2 commits May 7, 2024 00:55
Co-authored-by: Marko Stanimirović <markostanimirovic95@gmail.com>
…hnekamp/ngrx into feat/effects/migrator-operators
@rainerhahnekamp
Copy link
Contributor Author

@markostanimirovic if possible, I'd like to push the version that includes the fix of #4311 (comment) before this is merged.

@markostanimirovic
Copy link
Member

@markostanimirovic if possible, I'd like to push the version that includes the fix of #4311 (comment) before this is merged.

sounds good!

@timdeschryver timdeschryver added the Needs Cleanup Review changes needed label May 7, 2024
@timdeschryver timdeschryver removed the Needs Cleanup Review changes needed label May 8, 2024
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rainerhahnekamp !

@timdeschryver timdeschryver merged commit d264c56 into ngrx:main May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/effects: Add migration schematic for concatLatestFrom operator
3 participants