Fails to parse valid JSON

[martin-g]

I'm trying to parse JSON like:

{
  "success": 1,
  "return": {
    "343152": {
      "pair": "abcd",
      "type": "xyz",
      "start_amount": 13.345,
      "amount": 12.345,
      "rate": 485,
      "timestamp_created": 1342448420,
      "status": 0
    }
  }
}

But it fails with:

Exception in thread "main" java.io.IOException: Unexpected end of JSON input
	at com.dslplatform.json.JsonReader.read(JsonReader.java:292)
	at com.dslplatform.json.JsonReader.getNextToken(JsonReader.java:684)
	at com.dslplatform.json.ObjectConverter.deserializeMap(ObjectConverter.java:122)
	at com.dslplatform.json.ObjectConverter$4.read(ObjectConverter.java:31)
	at com.dslplatform.json.ObjectConverter$4.read(ObjectConverter.java:28)
	at com.dslplatform.json.DslJson.deserialize(DslJson.java:1263)
	at com.example.Test.main(Test.java:16)

I've tried to simplify the JSON to find what exactly causes the problem to:

{
  "a": 1,
  "b": {
    "c": {
      "d": "e"
    }
  }
}

but now it fails with:

Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.lang.String.<init>(String.java:196)
	at com.dslplatform.json.DslJson$SimpleStringCache.createAndPut(DslJson.java:539)
	at com.dslplatform.json.DslJson$SimpleStringCache.get(DslJson.java:530)
	at com.dslplatform.json.JsonReader.readKey(JsonReader.java:929)
	at com.dslplatform.json.ObjectConverter.deserializeMap(ObjectConverter.java:120)
	at com.dslplatform.json.ObjectConverter.deserializeObject(ObjectConverter.java:87)
	at com.dslplatform.json.ObjectConverter.deserializeMap(ObjectConverter.java:125)
	at com.dslplatform.json.ObjectConverter$4.read(ObjectConverter.java:31)
	at com.dslplatform.json.ObjectConverter$4.read(ObjectConverter.java:28)
	at com.dslplatform.json.DslJson.deserialize(DslJson.java:1263)
	at com.example.Test.main(Test.java:16)

My Java code is :

String json = "<ONE OF THE ABOVE SNIPPETS>";
DslJson<Object> dsl = new DslJson<>();
final Map deserialize = dsl.deserialize(Map.class, json.getBytes(StandardCharsets.UTF_8), 16);
System.err.println("des\n" + deserialize);

[zapov]

Why do you pass 16 as length instead of actual string length in utf8 bytes?

You should be doing something along the lines of

bytes[] json = "<snippet>".getBytes("UTF-8");
final Map deserialize = dsl.deserialize(Map.class, json, json.length);

[zapov]

btw. tnx for the bug report regarding StringIndexOutOfBoundsException. That's an unexpected exception which is now fixed.

btw2. the reason why there is no deserialize(Class, String) API is to discourage use of String. But I guess I could provide helper method for input bytes without asking for length (although thats not much better than String - since it does not encourage reuse)

[martin-g]

Actually in my application I used the InputStream version and it failed the same way as with the original/longer JSON.

…

On Oct 4, 2017 08:19, "zapov" ***@***.***> wrote: btw. tnx for the bug report regarding StringIndexOutOfBoundsException. That's an unexpected exception which is now fixed. btw2. the reason why there is no deserialize(Class, String) API is to discourage use of String. But I guess I could provide helper method for input bytes without asking for length — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOKQvaAI8Hp0gAMfmm5TciKN0Hs8Es6ks5soxVMgaJpZM4Ps0Ds> .

[martin-g]

I'll prepare another test case.

[martin-g]

It appeared to be a small typo in the JSON that caused the original problem.
Everything works just fine now!