Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra build action for arm #538

Closed
organom opened this issue Jan 28, 2022 · 7 comments
Closed

Add extra build action for arm #538

organom opened this issue Jan 28, 2022 · 7 comments

Comments

@organom
Copy link
Member

organom commented Jan 28, 2022

Based on #535

@organom organom self-assigned this Jan 29, 2022
@organom organom changed the title Add extra build action for android Add extra build action for arm Feb 9, 2022
@organom
Copy link
Member Author

organom commented Feb 9, 2022

@ilyash on arm I'm getting a failure on the test:

Issue

1: + Test: time() > 1466662171
1: [ERROR 1954-01-22 19:17:14 UTC] +--------------------------------------------------+
1: [ERROR 1954-01-22 19:17:14 UTC] | Test failed: time() > 1466662171. Returned false |
1: [ERROR 1954-01-22 19:17:14 UTC] +--------------------------------------------------+
1: [ERROR 1954-01-22 19:17:14 UTC] Exception of type Error occurred
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 0: <builtin-stdlib>:8087:2 - 8087:35
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 1: <builtin-stdlib>:8061:21 - 8061:30 [in bootstrap_exception_catch_wrapper]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 2: <builtin-stdlib>:7993:12 - 7993:24 [in bootstrap]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 3: /ngs/test.ngs:37:7 - 37:11
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 4: <builtin-stdlib>:2392:11 - 2392:13 [in each]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 5: /ngs/test.ngs:18:13 - 18:18 [in perform_tests_in_file]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 6: <builtin-stdlib>:5557:2 - 5557:9 [in lines]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 7: <builtin-stdlib>:2173:8 - 2173:14 [in finally]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 8: <builtin-stdlib>:3731:11 - 3731:14 [in Result]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 9: <builtin-stdlib>:5559:16 - 5559:21
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 10: <builtin-stdlib>:4354:12 - 4354:16 [in lines]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 11: <builtin-stdlib>:2392:11 - 2392:13 [in each]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 12: /ngs/test.ngs:25:4 - 25:16
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 13: /ngs/test.ngs:12:59 - 12:64 [in perform_test]

When running ngs -pi "time()" I get <Int -503036595>

How to reproduce

From inside your local root folder of ngs, run:
docker run -it --volume "${PWD}:/ngs" ghcr.io/ngs-lang/ngs/run-on-arch-ngs-lang-ngs-build-armv7-bullseye:latest

then

cd /ngs
./install.sh
(cd build && ctest -VV)
ngs -pi "time()"

Any idea?

@ilyash-b
Copy link
Contributor

ilyash-b commented Feb 10, 2022

@organom , suspect number one:

Should potentially be solved if #65 is done

@organom
Copy link
Member Author

organom commented Feb 10, 2022

tested with aarch64 and it works
image

Run as docker run -it --volume "${PWD}:/ngs" ghcr.io/ngs-lang/ngs/run-on-arch-ngs-lang-ngs-build-aarch64-bullseye:latest

Does this mean intel 32 will also not work?

@ilyash-b
Copy link
Contributor

99% sure any 32 bit will not work

@organom
Copy link
Member Author

organom commented Feb 10, 2022

image

Tested with different 64 bit architectures and they are working great

About the 32 bits ones, are we going to support them? or should we just stay with 64 bits for now ?

@ilyash-b
Copy link
Contributor

I'd leave 32 bit out for now. We can look into that if there will be demand from users.

@organom
Copy link
Member Author

organom commented Feb 13, 2022

merged

@organom organom closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants