fix database cursor leak in DataHelper class

I moved the cursor closing code outside the if block to make sure the cursor is closed even when it is empty (when getCount() returns 0).
labexp · Oct 9, 2016 · 9c162aa · 9c162aa
1 parent 63cac7e
commit 9c162aa
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/app/src/main/java/me/guillaumin/android/osmtracker/db/DataHelper.java b/app/src/main/java/me/guillaumin/android/osmtracker/db/DataHelper.java
@@ -351,6 +351,8 @@ public static File getTrackDirFromDB(ContentResolver cr, long trackId) {
 			if (trackPath != null) {
 				trackDir = new File(trackPath);
 			}
+		}
+		if (c != null && !c.isClosed()) {
 			c.close();
 			c = null;
 		}