Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull dependencies from jcenter #46

Merged
merged 1 commit into from Aug 4, 2015
Merged

Pull dependencies from jcenter #46

merged 1 commit into from Aug 4, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 31, 2015

All dependencies are also available on jcenter. If those are pulled from this location we could enable auto-updates on f-droid: https://f-droid.org/repository/browse/?fdfilter=osmtracker&fdid=me.guillaumin.android.osmtracker

The only problem i'm seeing here is, that slf4j-android-1.5.8.jar is not available on jcenter. The oldest version available is the 1.6.1-RC1:

https://bintray.com/bintray/jcenter/org.slf4j:slf4j-android

which i'm currently pulling in for the f-droid build.

@nguillaumin
Copy link
Contributor

Yeah I did that initially when I converted the project to Gradle but the lack of slf4j-android in the right version made me roll it back. Since SLF4j is used by OSMDroid it's not easy to know if upgrading it will break things or not.

What do you mean by "auto-updates on F-Droid"? How is that related to pulling the dependencies from Maven central instead of embedding them?

Thanks.

@ghost
Copy link
Author

ghost commented Aug 2, 2015

What do you mean by "auto-updates on F-Droid"? How is that related to pulling the dependencies from Maven central instead of embedding them?

The goal of f-droid is to replaced .jar files within an apps build process with "trusted" one from maven central / jcenter. Currently this is done by using this search/replace within the build.gradle:

https://gitlab.com/fdroid/fdroiddata/blob/master/metadata/me.guillaumin.android.osmtracker.txt#L69

which doesn't allow auto-building the app as the dependencies always needs to be checked if the correct versions are used. If the build.gradle is pulling all files directly from maven central / jcenter the auto-update could be enabled as it needs no manual check.

@nguillaumin
Copy link
Contributor

Ok makes sense. It seems osmdroid-android is using SLF4j 1.6.1 anyway according to their POM

nguillaumin added a commit that referenced this pull request Aug 4, 2015
Pull dependencies from jcenter
@nguillaumin nguillaumin merged commit e80e4a6 into labexp:master Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant