Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Material) FormlySliderTypeComponent is not exported #3094

Closed
wadefleming-nz opened this issue Dec 10, 2021 · 3 comments
Closed

(Material) FormlySliderTypeComponent is not exported #3094

wadefleming-nz opened this issue Dec 10, 2021 · 3 comments
Labels

Comments

@wadefleming-nz
Copy link

wadefleming-nz commented Dec 10, 2021

Description
I want to extend FormlySliderTypeComponent, however I cannot import it to my project.

It is not exported like other similar types ie: \src\material\select\src\public_api.ts:

export { FormlyMatSelectModule } from './select.module';
export { FormlyFieldSelect } from './select.type';     // << ------- type is exported

whereas \src\material\slider\src\public_api.ts has only:

export { FormlyMatSliderModule } from './slider.module';

Minimal Reproduction

Extend a type from FormlySliderTypeComponent as shown here: https://stackblitz.com/edit/ngx-formly-ui-material-49pves?file=src%2Ftypes%2Fslider-extended.type.ts

Note that FormlySliderTypeComponent auto imports from @ngx-formly/material/slider/slider.type which doesn't work as its not public, hence the app fails to compile.

Your Environment

  • Angular version: 13.0.0
  • Formly version: 5.10.26

Additional Info

I noticed that FormlyDatepickerTypeComponent and FormlyToggleTypeComponent are also not exported, and that all of the not-imported types have the Component suffix. Maybe there is something else going on here?

@aitboudad
Copy link
Member

This issue has been fixed and released as part of v5.10.27 release.

Please let us know, in case you are still encountering a similar issue/problem.
Thank you!

@wadefleming-nz
Copy link
Author

Wow, appreciate this being addressed so quickly!

I don't need them now but as above FormlyDatepickerTypeComponent and FormlyToggleTypeComponent area also similarly not exported and have the Component suffix. You may want to consider doing the same for them.

Thanks

@aitboudad
Copy link
Member

aitboudad commented Jan 8, 2022

I don't need them now but as above FormlyDatepickerTypeComponent and FormlyToggleTypeComponent area also similarly not exported and have the Component suffix. You may want to consider doing the same for them.

Done in v5.10.28 release.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants