Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormlyDatepickerTypeComponent is not listed as apart of the Formly Public API #3116

Closed
vitale232 opened this issue Jan 4, 2022 · 4 comments
Labels

Comments

@vitale232
Copy link
Contributor

Description
The FormlyDatepickerTypeComponent type is not exported from @ngx-formly/material/datepicker.

It appears the built-in types are re-exported for the other Material types (e.g. select, checkbox) . This appears to be present in both the v5 branch and main. It's affecting my ability to extend the type and re-write the template.

Minimal Reproduction

https://stackblitz.com/edit/ngx-formly-ui-material-ejvkjo?file=src%2Fapp%2Fcustom-datepicker%2Fcustom-datepicker.component.ts

Your Environment

  • Angular version: 13.1.0
  • Formly version: ^5.10.27

Additional context
I think this is simply an oversight, but if not, can you please provide an explanation as to why this particular type is private?

Also, here's another star :-) ⭐

@vitale232 vitale232 added the bug label Jan 4, 2022
@aitboudad
Copy link
Member

Would you like to provide a PR? Also FormlyToggleTypeComponent is missing as mentioned here #3094 (comment)

For naming:

  • FormlyFieldToggle
  • FormlyFieldDatepicker

@vitale232
Copy link
Contributor Author

Yes! I'd like to provide something. Should I PR v5, main, both?

@aitboudad
Copy link
Member

Yes! I'd like to provide something. Should I PR v5, main, both?

V5

vitale232 added a commit to vitale232/ngx-formly that referenced this issue Jan 4, 2022
vitale232 added a commit to vitale232/ngx-formly that referenced this issue Jan 4, 2022
aitboudad pushed a commit that referenced this issue Jan 5, 2022
Co-authored-by: Andrew Vitale <avitale@vhb.com>

fix #3094, fix #3116
@aitboudad
Copy link
Member

This issue has been fixed and released as part of v5.10.28 release.

Please let us know, in case you are still encountering a similar issue/problem.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants