Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"display: none" is not set when lazyRender is true #3313

Closed
yinglejia opened this issue May 27, 2022 · 4 comments
Closed

"display: none" is not set when lazyRender is true #3313

yinglejia opened this issue May 27, 2022 · 4 comments
Labels

Comments

@yinglejia
Copy link

yinglejia commented May 27, 2022

Description

We set lazyRender to true in our app and use hideExpression to conditionally hide some fields.

The problem we have is that even though the hidden fields are not rendered, the formly wrappers <formly-field> are still rendered and they do not have display: none. Therefore, they are still part of the visual tree and can break form layout (even though the height is 0).

Minimal Reproduction

https://stackblitz.com/...

Your Environment

  • Angular version: 12.2.15
  • Formly version: 5.12.0

Additional context
Add any other context about the problem here.

@aitboudad
Copy link
Member

This issue has been fixed and released as part of v5.12.3 release.

Please let us know, in case you are still encountering a similar issue/problem.
Thank you!

@yinglejia
Copy link
Author

@aitboudad Thank you very much!

@Trophalaxeur
Copy link

Trophalaxeur commented Sep 2, 2022

This issue has been fixed and released as part of v5.12.3 release.

Please let us know, in case you are still encountering a similar issue/problem. Thank you!

Hello @aitboudad ,
This fix works perfectly with Formly V5 but not with V6.
Is the fix merged on Formly V6 ?

Thanks :) !

@aitboudad
Copy link
Member

@Trophalaxeur could you please create a separate issue with a reproduction example. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants