-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"display: none" is not set when lazyRender is true #3313
Comments
This issue has been fixed and released as part of v5.12.3 release. Please let us know, in case you are still encountering a similar issue/problem. |
@aitboudad Thank you very much! |
Hello @aitboudad , Thanks :) ! |
@Trophalaxeur could you please create a separate issue with a reproduction example. Thank you! |
Description
We set
lazyRender
totrue
in our app and usehideExpression
to conditionally hide some fields.The problem we have is that even though the hidden fields are not rendered, the formly wrappers
<formly-field>
are still rendered and they do not havedisplay: none
. Therefore, they are still part of the visual tree and can break form layout (even though the height is 0).lazyRender
isfalse
, Formly addsdisplay: none
to<formly-field>
. https://github.com/ngx-formly/ngx-formly/blob/main/src/core/src/lib/components/formly.field.ts#L210lazyRender
istrue
, Formly does not adddisplay: none
. It seems it should?Minimal Reproduction
https://stackblitz.com/...
Your Environment
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: