Merge master onto 6.0.x branch (Angular 7 update) #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoval Updated to cordova-plugin-ionic-keyboard in place of deprecated keyboard plugin
Added redirect to previously saved url after login, if you are not authenticated.
Update to Angular 7
Also fixed readme
Migrated generator code base to xo + prettier and async/await
- Added no redundant jsdoc tslint rule - Removed redundant jsdoc type annotations - Fixed deprecated forRoot() NgbModule init
Updated tslint rules, polyfills and some fixes
# Conflicts: # generators/app/templates/_package.json # generators/app/templates/src/app/_app.component.spec.ts # generators/app/templates/src/app/_app.component.ts # generators/app/templates/src/app/_app.module.ts # generators/app/templates/src/theme/__ionic.theme-variables.scss
sinedied
changed the title
|
With Ionic beta15, should be good 😃 |
sinedied
force-pushed
the
feature/merge-master
branch
from
0d47187
to
725b63a
Compare
|
FYI I made a PR towards this branch for easy review here: #411 The good news is that their new tabs seem a lot less buggy for our use case compared to before. The bad news, as I mentioned in the PR...
|
…pdates Updated ionic to beta 16 and migrated for tabs breaking changes
|
Spent all day on it, but found a workaround for Ionic e2e issue 🎉 |
|
Hopefully this will allow merging, then after that we can start polishing the Ionic templates and ironing out small issues to prepare for release 😄 FYI Ionic 4 is expected early January for a final version |
|
Wow bravo! Snazzy! :) So does this mean the loading controller test issue snuck away too? I didn't see a change related to it. |
|
\o/ looks like the ionic builds are passing! cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have put a separate branch for this as some fixes are needed due to TS 3 update on the Ionic part.
Seems like we need to wait for the next Ionic beta that may fix typings issues until this can be merged (and first 6.0.0-beta released) :/