Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async/await e2e and disable selenium promise manager (closes #399) #425

Conversation

captaincaius
Copy link
Contributor

deprecated SELENIUM_PROMISE_MANAGER now set to false so release/6.0 will be a little more future-proof ;)

@sinedied
Copy link
Member

sinedied commented Jan 7, 2019

Perfect! It might also be useful to add a note on this and a link to https://www.protractortest.org/#/async-await in the e2e test guide 😉

@captaincaius
Copy link
Contributor Author

Yup you're right - I'll try to add a commit to this PR tonight. Maybe a quick note too saying that older examples you might find on the internet might be missing async/await because they might have had it enabled or something.

@captaincaius
Copy link
Contributor Author

Hmm... something up w/ the appveyor builds? Seems unrelated to the PR.

@sinedied
Copy link
Member

Yes it's strange, maybe related to latest ng-cli update :/
Since travis is OK, we can merge this anyways after you've updated the docs.

@captaincaius
Copy link
Contributor Author

Perfect! It might also be useful to add a note on this and a link to https://www.protractortest.org/#/async-await in the e2e test guide

Donezo. maybe I got a little carried away with the advertisements to protractor's docs but at least it's super clear :D. LMK if it needs revision.

@sinedied
Copy link
Member

That's perfect 😉

@sinedied sinedied merged commit 59cbabb into ngx-rocket:release/6.0.x Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants