Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support mutate object outside immer #232

Merged
merged 5 commits into from Jun 15, 2019
Merged

fix: support mutate object outside immer #232

merged 5 commits into from Jun 15, 2019

Conversation

splincode
Copy link
Member

No description provided.

@splincode splincode changed the title Bugfix/selector fix: incorrect finished draft Jun 14, 2019
@splincode splincode requested a review from arturovt June 14, 2019 21:23
@splincode splincode mentioned this pull request Jun 14, 2019
Closed
arturovt
arturovt approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@arturovt arturovt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, just fix those minor changes.

src/lib/core/immer-adapter/common/immutable-state-context.ts Outdated Show resolved Hide resolved
src/lib/core/immer-adapter/common/immutable-state-context.ts Outdated Show resolved Hide resolved
src/lib/core/immer-adapter/common/immutable-state-context.ts Outdated Show resolved Hide resolved
src/tests/helpers/app.state.ts Outdated Show resolved Hide resolved
@splincode splincode changed the title fix: incorrect finished draft feat: support unmutated object Jun 15, 2019
@splincode splincode changed the title feat: support unmutated object fix: correct reusable mutate object without immer Jun 15, 2019
@splincode splincode changed the title fix: correct reusable mutate object without immer fix: correct reusable mutate object outside immer Jun 15, 2019
@splincode splincode changed the title fix: correct reusable mutate object outside immer fix: support mutate object outside immer Jun 15, 2019
@splincode splincode merged commit c8b559d into master Jun 15, 2019
@elvisfernandes elvisfernandes mentioned this pull request Jun 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturovt arturovt arturovt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@splincode @arturovt