Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶[BUG]: ngxs-cli - generated code - contains nbsp and the spec uses deprecated code #9

Closed
dinbtechit opened this issue Aug 16, 2023 · 0 comments

Comments

@dinbtechit
Copy link
Contributor

Affected Package

@ngxs/cli

Is this a regression?

No, this issue has been ever since I started using ngxs cli version

Description

The code generated by ngxs-cli includes non-breaking space characters (nbsp), and the spec utilizes deprecated code.
I'm writing an intellij/webstorm plugin for ngxs. It would be nice to have the ngxs cli working correctly.

馃敩 Minimal Reproduction

  1. Follow the steps here -> https://www.ngxs.io/plugins/cli to install @ngxs/cli.

  2. Generate a store using ngxs cli command

ngxs --name mystore --spec true --folder-name mystore
  1. Now examine the generated files.

my-store.state.ts:

The injectable import contains NBSP in it.

image

my-store.state.spec.ts

Uses deprecated code. I would additionally modify the boilerplate test case to simply verify the truthiness of the state. The default test case isn't particularly helpful.

image

Libs:

  • @angular/cli version: 2.0.0
  • @ngxs/store version: 3.8.0

Browser: N/A

For Tooling issues:

  • Node version: v16.17.0
  • npm version - 9.3.1
  • Platform: MacOS Apple M1 Pro - Ventura
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant