You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue is caused by package @ngxs/router-plugin
Is this a regression?
Yes, the previous version in which this bug was not present was: 3.4.3
Description
Links containing the #anchor fragment do not work correctly in version 3.5.0.
Opening the page containing #anchor causes the #anchor fragment is removed from the URL.
For version 3.4.3 this fragment remains in the URL
Libs:
- @angular/core version: 8.0.0
- @ngxs/store version: 3.5.0
Browser:
- [x] Chrome (desktop) version 76.0.3809.100
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [x] Safari (desktop) version 12.1.2
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
For Tooling issues:
- Node version: 12.6.0
- Platform: Mac
Others:
The text was updated successfully, but these errors were encountered:
includeHash option only partly solves the problem.
In the previous version of ngxs (3.4.3) the "anchor" links worked fine despite the "includeHash" parameter missing.
I would like this behavior to remain as it was in the previous version (customer requirements are that links should not contain # (except anchors)
Affected Package
The issue is caused by package @ngxs/router-pluginIs this a regression?
Yes, the previous version in which this bug was not present was: 3.4.3Description
Links containing the #anchor fragment do not work correctly in version 3.5.0.
Opening the page containing #anchor causes the #anchor fragment is removed from the URL.
For version 3.4.3 this fragment remains in the URL
馃敩 Minimal Reproduction
I have prepared two versions of the test, for ngxs ver 3.5.0 and ver 3.4.3.
Click on the "OPEN NEW WINDOW" link and you will see that for version 3.5.0 url does not contain a #anchor fragment
not working 3.5.0 version https://stackblitz.com/edit/ngxs-plugin-350
working 3.4.3 version https://stackblitz.com/edit/ngxs-plugin-343
馃敟 Exception or Error
Environment
The text was updated successfully, but these errors were encountered: