Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶[BUG]: Links contains #anchor doesn't work as expected #1257

Closed
woj-wi opened this issue Aug 21, 2019 · 5 comments
Closed

馃悶[BUG]: Links contains #anchor doesn't work as expected #1257

woj-wi opened this issue Aug 21, 2019 · 5 comments
Assignees
Milestone

Comments

@woj-wi
Copy link

woj-wi commented Aug 21, 2019

Affected Package

The issue is caused by package @ngxs/router-plugin

Is this a regression?

Yes, the previous version in which this bug was not present was: 3.4.3

Description

Links containing the #anchor fragment do not work correctly in version 3.5.0.
Opening the page containing #anchor causes the #anchor fragment is removed from the URL.
For version 3.4.3 this fragment remains in the URL

馃敩 Minimal Reproduction

I have prepared two versions of the test, for ngxs ver 3.5.0 and ver 3.4.3.
Click on the "OPEN NEW WINDOW" link and you will see that for version 3.5.0 url does not contain a #anchor fragment
not working 3.5.0 version https://stackblitz.com/edit/ngxs-plugin-350
working 3.4.3 version https://stackblitz.com/edit/ngxs-plugin-343

馃敟 Exception or Error





Environment


Libs:
- @angular/core version: 8.0.0
- @ngxs/store version: 3.5.0


Browser:
- [x] Chrome (desktop) version 76.0.3809.100
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [x] Safari (desktop) version 12.1.2
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: 12.6.0
- Platform:  Mac

Others:

@splincode
Copy link
Member

@arturovt what do you think about this bug?

@arturovt
Copy link
Member

As we release on the next monday I still have to time to debug.

I will get back from job today and see how this can be fixed.

@woj-wi
Copy link
Author

woj-wi commented Aug 27, 2019

includeHash option only partly solves the problem.
In the previous version of ngxs (3.4.3) the "anchor" links worked fine despite the "includeHash" parameter missing.
I would like this behavior to remain as it was in the previous version (customer requirements are that links should not contain # (except anchors)

@markwhitfeld markwhitfeld added this to the 3.5.x milestone Aug 29, 2019
@markwhitfeld
Copy link
Member

Please could you confirm that this is fixed with the v3.5.1 release?

@woj-wi
Copy link
Author

woj-wi commented Aug 29, 2019

With the v3.5.1 works like a charm :),
Thx for your effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants