fix(router-plugin): "includeHash" must be truthy requesting path

[arturovt]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1257

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@markwhitfeld @splincode FYI

true argument is includeHash. It is false by default, so location.hash is not included. Setting includeHash to true will also include location.hash.

I understand that this piece of code is pesky. I am thinking on the workarounds for v4.

[markwhitfeld]

Is there a way to do a test for this?
Were you able to simulate the scenario in an app?

[arturovt]

Is there a way to do a test for this?
Were you able to simulate the scenario in an app?

Yes, sure. I always debug router issues in real apps.

[arturovt]

Is there a way to do a test for this?
Were you able to simulate the scenario in an app?

Yes, sure. I always debug router issues in real apps.

Yes, we can test it. There is an opened PR regarding E2E tests awaiting your approval 😉